Closed
Bug 216257
Opened 21 years ago
Closed 20 years ago
Add "Events this month" to dropdown selection list in events pane.
Categories
(Calendar :: Sunbird Only, enhancement, P4)
Calendar
Sunbird Only
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k_b0000, Assigned: mattwillis)
Details
Attachments
(1 file, 2 obsolete files)
191.73 KB,
patch
|
mostafah
:
first-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030812 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030812; cal 20030811 wish: adding selection for "Events this month" to dropdown selection list in events pane. Reproducible: Always Steps to Reproduce:
Assignee | ||
Comment 1•20 years ago
|
||
Reasonable enhancement request. status -> NEW hardware/OS -> ALL component -> Front End priority -> P4 Taking
Assignee: mostafah → mattwillis
Status: UNCONFIRMED → NEW
Component: General → Calendar Front End
Ever confirmed: true
OS: Linux → All
Priority: -- → P4
Hardware: PC → All
Comment 2•20 years ago
|
||
Please cc me on bugs you reassign.
Assignee | ||
Comment 3•20 years ago
|
||
Reporter: "Events in the Next Month" brings up events for the next 31 days, irrespective of the calendar month. Does this do what you want, albeit with a possible poor choice of label, or do you want a selection where where today is October 22, you can see all of October's events?
Assignee | ||
Comment 5•20 years ago
|
||
This patch adds "Events in this calendar month" as an option. It also clarifies the other options, "next 7 days", "next 14 days", "next 31 days"
Assignee | ||
Updated•20 years ago
|
Attachment #163044 -
Flags: first-review?(mostafah)
Assignee | ||
Updated•20 years ago
|
Attachment #163044 -
Flags: first-review?(mostafah)
Assignee | ||
Comment 6•20 years ago
|
||
Attachment #163044 -
Attachment is obsolete: true
Comment 7•20 years ago
|
||
Comment on attachment 163047 [details] [diff] [review] rev1 - trunk - diff run with -u8pN (sorry) minusing review from me... (no review originally requested) [I am not officially a peer, though this I can save mostafah time on] >RCS file: /cvsroot/mozilla/calendar/resources/locale/cs-CZ/calendar.dtd,v >-<!ENTITY calendar.events.filter.week.label "Události tohoto tĂ˝dne"> >-<!ENTITY calendar.events.filter.2weeks.label "Události přÚtĂch dvou tĂ˝dnĹŻ"> >-<!ENTITY calendar.events.filter.month.label "Události následujĂcĂho mÄ›sĂce"> >+<!ENTITY calendar.events.filter.next7Days.label "Události tohoto tĂ˝dne"> >+<!ENTITY calendar.events.filter.next14Days.label "Události přÚtĂch dvou tĂ˝dnĹŻ"> >+<!ENTITY calendar.events.filter.thisCalendarMonth.label "Events in this Calendar Month"> >+<!ENTITY calendar.events.filter.next31Days.label "Události následujĂcĂho mÄ›sĂce"> Nit: Try to keep consistent Ordering (See Next), the following section would be easiest to fix >RCS file: /cvsroot/mozilla/calendar/resources/locale/en-US/calendar.dtd,v >-<!ENTITY calendar.events.filter.week.label "Events This Week"> >-<!ENTITY calendar.events.filter.2weeks.label "Events Next 2 Weeks"> >-<!ENTITY calendar.events.filter.month.label "Events In The Next Month"> >+<!ENTITY calendar.events.filter.next7Days.label "Events in the Next 7 Days"> >+<!ENTITY calendar.events.filter.next14Days.label "Events in the Next 14 Days"> >+<!ENTITY calendar.events.filter.next31Days.label "Events in the Next 31 Days"> >+<!ENTITY calendar.events.filter.thisCalendarMonth.label "Events in this Calendar Month"> >RCS file: /cvsroot/mozilla/calendar/sunbird/base/content/calendar.xul,v > <menuitem id="event-filter-today" > label="&calendar.events.filter.today.label;" > value="today"/> >- <menuitem id="event-filter-week" >+ <menuitem id="event-filter-next7Days" > label="&calendar.events.filter.week.label;" >- value="week"/> >+ value="next7Days"/> > <menuitem id="event-filter-2weeks" > label="&calendar.events.filter.2weeks.label;" > value="2weeks"/> >- <menuitem id="event-filter-month" >- label="&calendar.events.filter.month.label;" >- value="month"/> >+ <menuitem id="event-filter-next31Days" >+ label="&calendar.events.filter.next31Days.label;" >+ value="next31Days"/> >+ <menuitem id="event-filter-thisCalendarMonth" >+ label="&calendar.events.filter.thisCalendarMonth.label;" >+ value="thisCalendarMonth"/> You missed [all] the label and value changes in here, please correct. Thanks for your effort on this, personally the rest looks good. (though r? mostafah and not me for revised patch)
Attachment #163047 -
Flags: first-review-
Comment 8•20 years ago
|
||
If you add 'events this calendar month', you should also add 'events this calendar week' etc. This makes the list real long. Is this a good idea?
Assignee | ||
Comment 9•20 years ago
|
||
(In reply to comment #8) > If you add 'events this calendar month', you should also add 'events this > calendar week' etc. This makes the list real long. Is this a good idea? I guess that's up to Mostafa. I'll add it if he wants it.
Assignee | ||
Comment 10•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #163047 -
Attachment is obsolete: true
Assignee | ||
Updated•20 years ago
|
Attachment #163130 -
Flags: first-review?(mostafah)
Comment 11•20 years ago
|
||
The question is _why_ you want to add events this calendar month. comment 0 doesn't give any reason.
Comment 12•20 years ago
|
||
See Bug 262729, reporter's previous request.
Comment 13•20 years ago
|
||
Comment on attachment 163130 [details] [diff] [review] rev2 - trunk - fixes Justin's comments, and removes DOS lines breaks from 3 .dtd files However I will keep the current entities in the dtd files as they are and just add the new ones. There is a strong chance of us needing them later.
Attachment #163130 -
Flags: first-review?(mostafah) → first-review+
Comment 14•20 years ago
|
||
Checked in. Thanks
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Comment 15•18 years ago
|
||
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird
You need to log in
before you can comment on or make changes to this bug.
Description
•