21628 - Implement nsIDirectoryService

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Doug Turner (:dougt)]

Need a service to replace nsSpecialSystemDirectory and nsFileLocations for use
with nsIFile.

Comment 1

[Doug Turner (:dougt)]

got first cut of it implemented and checked into our branch.  Further work is
needed to support everything that nsSpecialSystemDirectory and nsFileLocations
did.

Comment 2

[Doug Turner (:dougt)]

moving into the m14 bucket.

Comment 3

[Doug Turner (:dougt)]

moving to m15

Comment 4

[Warren Harris]

Suresh Duddi wrote:

  Warren Harris wrote:
  > 3. The "special" directory service implementations are indeed special
  > (as in "special education"). We saw one call to
  > nsSpecialSystemDirectory::nsSpecialSystemDirectory make 16 calls to
  > nsSpecialSystemDirectory::=, and most of the time there went to
  > GetWindowsFolder and then to GetCurrentProcessDirectory. These should
  > probably be called on demand and cached since I don't think they ever
  > change. I think the new directory service provider architecture (with
  > callbacks) should help here considerably.

  I agree. You should file a bug on this if this needs to get fixed for
  beta.

Comment 5

[Doug Turner (:dougt)]

I have changes which will make this an extendable service.  I have tested on 
linux and the mac, and have been running this on windows for at least two weeks.  
It cleans up a memory leak as well.  needs pdt+ approval.

Comment 6

[Suresh Duddi (gone)]

I think you wanted TFV to be M14 not M9. Changing...

Comment 7

[daver]

So why do you need this for beta1?  How big is the leak?

Comment 8

[Doug Turner (:dougt)]

every Set() a nsLocalFile is lost.  which is not that much.  The bug for this 
leak was written up by beard:

http://bugzilla.mozilla.org/show_bug.cgi?id=25584

I change how it all works, and I this is the bug for the new implementation.

Comment 9

[Doug Turner (:dougt)]

Fixed checked in.,

Comment 10

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/9c7ae553850c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/21628: catch ComposeNotIdleException