Closed Bug 21629 Opened 25 years ago Closed 24 years ago

some frames are being passed to interfaces that assume refcounting

Categories

(Core :: Layout: Form Controls, defect, P3)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: buster, Assigned: rods)

References

Details

(Keywords: memory-footprint, memory-leak, Whiteboard: [nsbeta3+]; requesting engineer feedback-ckritzer;) 

nsListControlFrame, nsFileControlFrame, and nsComboBoxControlFrame all suffer
from the same basic problem as nsSliderFrame:  they implement listener
interfaces directly but they are not refcounted objects.  They should create
intermediate event listener objects that contain a weak reference back to the
frame they represent.  They also should not override AddRef() and Release()
See bug 21571 for details.
Depends on: 21571
Target Milestone: M13
I completely agree with Steve's analysis of the problem and his proposed
solution
I really only want to do this once, so I am going to wait until we have the
nsGfxListControlFrame working.
GfxListbox probably won't be done until M14, so moving this to M14
Target Milestone: M13 → M14
changing to M14
changing to M15
Target Milestone: M14 → M15
This is fixed for GfxList and I am closing it out now.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Reopening because this was fixed for just GfxList and now needs to be fixed for 
for non Gfx Listbox
Status: RESOLVED → REOPENED
Keywords: footprint, mlk, nsbeta3
Resolution: FIXED → ---
Marking nsbeta3+
Whiteboard: [nsbeta3+]
fixed
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Anyone have suggestions for how to test this?
Whiteboard: [nsbeta3+] → [nsbeta3+]; requesting engineer feedback-ckritzer;
It's a code-level fix.  Whoever reviewed it for Rod should verify.
there isn't anyway to test it, 
Fair enough.  Thanks Buster, Rods for your comments.

Based on engineering comments, marking VERIFIED FIXED on:
- LinuxRH62 2000-09-13-08-M18 Commercial
- Win98     2000-09-13-08-M18 Mozilla
- MacOS86   2000-09-13-04-M18 Commercial
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.