some frames are being passed to interfaces that assume refcounting

VERIFIED FIXED in M15

Status

()

Core
Layout: Form Controls
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: buster, Assigned: rods (gone))

Tracking

({footprint, mlk})

Trunk
x86
Windows NT
footprint, mlk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3+]; requesting engineer feedback-ckritzer;)

(Reporter)

Description

18 years ago
nsListControlFrame, nsFileControlFrame, and nsComboBoxControlFrame all suffer
from the same basic problem as nsSliderFrame:  they implement listener
interfaces directly but they are not refcounted objects.  They should create
intermediate event listener objects that contain a weak reference back to the
frame they represent.  They also should not override AddRef() and Release()
See bug 21571 for details.
(Reporter)

Updated

18 years ago
Depends on: 21571
Target Milestone: M13

Comment 1

18 years ago
I completely agree with Steve's analysis of the problem and his proposed
solution
(Assignee)

Comment 2

18 years ago
I really only want to do this once, so I am going to wait until we have the
nsGfxListControlFrame working.
(Assignee)

Comment 3

18 years ago
GfxListbox probably won't be done until M14, so moving this to M14
(Assignee)

Updated

18 years ago
Target Milestone: M13 → M14
(Assignee)

Comment 4

18 years ago
changing to M14
(Assignee)

Comment 5

18 years ago
changing to M15
Target Milestone: M14 → M15
(Assignee)

Comment 6

18 years ago
This is fixed for GfxList and I am closing it out now. 
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

18 years ago
Reopening because this was fixed for just GfxList and now needs to be fixed for 
for non Gfx Listbox
Status: RESOLVED → REOPENED
Keywords: footprint, mlk, nsbeta3
Resolution: FIXED → ---
Marking nsbeta3+
Whiteboard: [nsbeta3+]
(Assignee)

Comment 9

18 years ago
fixed 
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 10

18 years ago
Anyone have suggestions for how to test this?
Whiteboard: [nsbeta3+] → [nsbeta3+]; requesting engineer feedback-ckritzer;
(Reporter)

Comment 11

18 years ago
It's a code-level fix.  Whoever reviewed it for Rod should verify.
(Assignee)

Comment 12

18 years ago
there isn't anyway to test it, 

Comment 13

18 years ago
Fair enough.  Thanks Buster, Rods for your comments.

Based on engineering comments, marking VERIFIED FIXED on:
- LinuxRH62 2000-09-13-08-M18 Commercial
- Win98     2000-09-13-08-M18 Mozilla
- MacOS86   2000-09-13-04-M18 Commercial
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.