216359 - Search Bar menu item does not stay unchecked in Address Book

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Bronson C. Elliott]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030813 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030813 Mozilla Firebird/0.6.1+

The Search Bar menu item is always reset to 'checked' everytime the Address Book
is opened regardless if the Search Bar toolbar is actually turned on or not.

Reproducible: Always

Steps to Reproduce:
1. Turn Search Bar toolbar off. View -> Toolbars -> Uncheck Search Bar.
2. Exit Address Book
3. Enter Address Book
4. Search Bar menu item is marked as checked even though the Search Bar toolbar
is turned off.
5. Select the menu item again and it is unchecked but the Search Bar toolbar
appears.
6. Repeat steps 2 and 3.
7. The Search Bar menu item is again marked as checked.

Actual Results:  
The Search Bar menu item is reset to checked everytime the Address Book is opened.

Expected Results:  
The Search Bar menu item should be checked/unchecked depending on the Search Bar
toolbar's status (on/off).

More information at:
http://forums.mozillazine.org/viewtopic.php?t=20207

Comment 1

[Malte Rücker (mbr)]

Attachment: adds missing id for menuitem

The menuitem for the Search Toolbar was missing an id, this prevented that the
state was remembered.

Comment 2

[Malte Rücker (mbr)]

Attachment: add missing id (corrected)

Sorry, my previous patch was missing the first three lines, mysteriously.

Comment 3

[Scott MacGregor]

fixed. thanks for the patch!