216366 - configure doesn't wrap all ActiveState Perl calls

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Benjamin Smedberg]

On win32 I am using an absolute MOZ_OBJDIR:
mk_add_options MOZ_OBJDIR=h:/moz-extension

But this recently began to fail, due to cygwin wrapper changes. We're calling
perl acoutput-fast.pl using cygwin paths. Patch forthcoming.

Comment 1

[Benjamin Smedberg]

Attachment: configure wraps AS perl

Comment 2

[Benjamin Smedberg]

Comment on attachment 129912 [details] [diff] [review]
configure wraps AS perl

tested with win32 AS perl and linux...

Comment 3

[cls]

Actually, bryner & I were discussing just dropping support for AS perl
altogether. The only thing that required it was the installer scripts (as
mentioned on the distribution page) and I believe that bug has been fixed.

Comment 4

[cls]

Comment on attachment 129912 [details] [diff] [review]
configure wraps AS perl

I'd rather not expand the CYGWIN_WRAPPER definition in the variables that use
it unless they are being used by configure.  

Since you're removing that entire block that sets my_perl, you should just get
rid of $my_srcdir as well since it's hardcoded to $srcdir now.

Comment 5

[Benjamin Smedberg]

Attachment: configure sraps AS perl, take 2

This patch only evaluates $PERL immediately.

Please don't decide to stop support AS perl... I know that cygwin perl may be
better for mozilla, but for other projects AS Perl avoids the overhead of
cygwin processes, and so I need it ahead of cygwin perl in my path.

Comment 6

[cls]

Comment on attachment 130177 [details] [diff] [review]
configure sraps AS perl, take 2

Path order is a non-issue as you can always set PERL in your mozconfig file to
point to the proper binary.

Comment 7

[Benjamin Smedberg]

Comment on attachment 130177 [details] [diff] [review]
configure sraps AS perl, take 2

Configure changes, should not affect the build at all.

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 130177 [details] [diff] [review]
configure sraps AS perl, take 2

a=asa (on behalf of drivers) for checkin to 1.5beta. Land quickly if it's gonna
make beta. Thanks.

Comment 9

[Benjamin Smedberg]

fixed-on-trunk, and ctlbld did its thing successfully.

Comment 10

[Benjamin Smedberg]

Ok, this caused regressions using make 3.80... the cygwin-wrapper is causing
substitution of the DOS-style path at acoutput-fast. I think I have a solution
in hand... it involves adding a "-first" flag to cygwin-wrapper such that the
wrapper will only wrap the first argument, and leave all the rest unmolested.

Comment 11

[Benjamin Smedberg]

Attachment: Fix for make 3.80

I have tested this patch with the following configurations:
make 3.79/AS Perl
make 3.80/cygwin perl
some ordinary linux configuration

Comment 12

[Benjamin Smedberg]

Fixed on trunk.