21639 - Progress meter paints three times for each update

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Simon Fraser [no longer active]]

The progress meter frame is ignoring the aWhichLayer parameter to its paint
method, so is drawing three times too often.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Diff for nsProgressMeterFrame.cpp

Comment 2

[Simon Fraser [no longer active]]

This diff changes teh Paint() method to only paint the progress bar when we're
painting the foreground layer.

I'd also suggest that ANIMATION_SPEED should be increased from 50 ms to something
more reasonable like 200 ms, to avoid spending lots of time drawing the progress
meter.

Comment 3

[Mike Pinkerton (not reading bugmail)]

patch looks good, i agree with the ANIMATION_SPEED constant. My only question is
200ms still too fast?

Check it in if you want. r=pinkerton.

Comment 4

[Simon Fraser [no longer active]]

Fix checked in

Comment 5

[sairuh (rarely reading bugmail)]

marking verified...