216480 - Customize MailViews: checkbox to show views for Labels

Status: RESOLVED WONTFIX

(MailNews Core :: Filters, enhancement)

Description

[Joe Infla]

Mozilla 1.4, WinXP

Add a checkbox in the Customize Message Views window to hide the five default
Labels views.  I don't use labels much at all, and those label views are always
there above my customizable views.

Comment 1

[Jo Hermans]

Well, you can customize them too, change their name and definition. Or remove
them entirely. The 5 default views are just what their name tells you : default
views, for people that don't know how to configure views.

Recommend WONTFIX, because it's UI-bloat for most users. And it's easy to work
around for those who know how to configure views (which is the point here).

Comment 2

[Joe Infla]

Attachment: visual example

I guess I wasn't clear enough in the description, sorry.  In the graphic,
you'll note that the five Labels (Important, Work, etc.) stay there even if you
erase one of their names.  Their location is hard-coded into the XUL at:
http://lxr.mozilla.org/seamonkey/source/mailnews/extensions/mailviews/resources/content/msgViewPickerOverlay.xul#40

I'm basically just suggesting adding a persist="hidden" to those, with a
checkbox in the "Customize..." box to toggle the state.  That way, the people
who know how to customize views at all will be able to customize the whole
view, rather than just part of it.
I've got most of a patch prepared; please don't wontfix it until you see what I
have in mind....

Comment 3

[Joe Infla]

Attachment: patch 90% complete

This patch correctly observes the boolean pref
mailnews.view.showLabelMenuItems, and places a checkbox "Show Label Views"
within the Customize Message Views dialog.  Everything functions well, except
showing the label views again after making them hidden.  I don't know why it
doesn't work yet, but I hope to figure it out soon.

Comment 4

[Joe Infla]

Attachment: complete patch

tested in recent trunk, ready for review.  This places a checkbox in the
Customize Message Views dialog to toggle showing the five label views.

Comment 5

[Joe Infla]

Attachment: checkbox label correction

Comment 6

[Karsten Düsterloh]

Since labels are tags now and you can remove all tags, this is WONTFIX.