216523 - t/Support/Files.pm fails to include Bugzilla/Template/Plugin/Bugzilla.pm in the file list

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Dave Miller [:justdave]]

t/Support/Files.pm fails to include Bugzilla/Template/Plugin/Bugzilla.pm in the
file list.

The code which looks for files to test only recurses two levels deep under the
Bugzilla directory.

Comment 1

[Zach Lipton [:zach]]

Attachment: Patch v1

Let's put the right patch on the right bug this time ;)

It would be good to use File::Find and do this the "right" way, but I think
this will do the job for now.

Comment 2

[Jouni Heikniemi]

Comment on attachment 130007 [details] [diff] [review]
Patch v1


>-@files = (glob($file), glob('Bugzilla/*.pm'), glob('Bugzilla/*/*.pm'));
>+@files = (glob($file), glob('Bugzilla/*.pm'), glob('Bugzilla/*/*.pm'), glob('Bugzilla/*/*/*.pm'));

Wrap the line so that it doesn't exceed 80 chars, and r=jouni.

Comment 3

[Vlad Dascalu]

Attachment: Zach's patch with jouni's comments

Comment 4

[Jouni Heikniemi]

Comment on attachment 135840 [details] [diff] [review]
Zach's patch with jouni's comments

Sure...

Comment 5

[Dave Miller [:justdave]]

wish it used File::Find, but oh well :)

Comment 6

[Dave Miller [:justdave]]

zach: ping

Comment 7

[Vlad Dascalu]

Zach, how about a CVS commit on this? :)

If you want me to do it or somebody else with CVS commit privs for webtools, I'm
sure they'll be happy to help. :)

Comment 8

[Vlad Dascalu]

If nobody checks this in by the end of this week, then I'll take the liberty to
checkin it myself, unless someone strongly objects.

Comment 9

[Gervase Markham [:gerv]]

Check it in :-)

Gerv

Comment 10

[Vlad Dascalu]

Checking in t/Support/Files.pm;
/cvsroot/mozilla/webtools/bugzilla/t/Support/Files.pm,v  <--  Files.pm
new revision: 1.15; previous revision: 1.14
done