t/Support/Files.pm fails to include Bugzilla/Template/Plugin/Bugzilla.pm in the file list. The code which looks for files to test only recurses two levels deep under the Bugzilla directory.
Created attachment 130007 [details] [diff] [review] Patch v1 Let's put the right patch on the right bug this time ;) It would be good to use File::Find and do this the "right" way, but I think this will do the job for now.
Comment on attachment 130007 [details] [diff] [review] Patch v1 >-@files = (glob($file), glob('Bugzilla/*.pm'), glob('Bugzilla/*/*.pm')); >+@files = (glob($file), glob('Bugzilla/*.pm'), glob('Bugzilla/*/*.pm'), glob('Bugzilla/*/*/*.pm')); Wrap the line so that it doesn't exceed 80 chars, and r=jouni.
Attachment #130007 - Flags: review? → review+
Created attachment 135840 [details] [diff] [review] Zach's patch with jouni's comments
Attachment #130007 - Attachment is obsolete: true
Comment on attachment 135840 [details] [diff] [review] Zach's patch with jouni's comments Sure...
Attachment #135840 - Flags: review+
wish it used File::Find, but oh well :)
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 2.18
Zach, how about a CVS commit on this? :) If you want me to do it or somebody else with CVS commit privs for webtools, I'm sure they'll be happy to help. :)
If nobody checks this in by the end of this week, then I'll take the liberty to checkin it myself, unless someone strongly objects.
Check it in :-) Gerv
Checking in t/Support/Files.pm; /cvsroot/mozilla/webtools/bugzilla/t/Support/Files.pm,v <-- Files.pm new revision: 1.15; previous revision: 1.14 done
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.