Closed Bug 216564 Opened 22 years ago Closed 22 years ago

Editor adds "title" attribute for images without titles

Categories

(SeaMonkey :: Composer, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Unassigned)

Details

(4 keywords)

Attachments

(1 file)

This is probably a regression from Bug 68800. Editor always sets the title attribute on an image; instead when the title is blank it should remove the attribute instead of using title=""
I see this bug on 1.4 builds (Netscape 7.1) on Mac OSX so the bug goes back before 7/1 at least.
Keywords: helpwanted
OS: Windows 95 → All
Hardware: PC → All
Attached patch Proposed patchSplinter Review
Attachment #130018 - Flags: superreview?(rbs)
Attachment #130018 - Flags: review?(brade)
Attachment #130018 - Flags: review?(brade) → review+
Attachment #130018 - Flags: superreview?(rbs) → superreview+
Comment on attachment 130018 [details] [diff] [review] Proposed patch Low-risk patch to avoid minor bloat in generated HTML.
Attachment #130018 - Flags: approval1.5b?
Attachment #130018 - Flags: approval1.4.x?
Comment on attachment 130018 [details] [diff] [review] Proposed patch a=asa (on behalf of drivers) for checkin to 1.5beta
Attachment #130018 - Flags: approval1.5b? → approval1.5b+
Comment on attachment 130018 [details] [diff] [review] Proposed patch This is not going to make 1.4.1. Please re-request aproval after 1.4.1 ships if you'd like to get this in for 1.4.2.
Attachment #130018 - Flags: approval1.4.x? → approval1.4.x-
Comment on attachment 130018 [details] [diff] [review] Proposed patch Sorry, another one I forgot to check in earlier :-[
Attachment #130018 - Flags: approval1.5?
Attachment #130018 - Flags: approval1.4.2?
Comment on attachment 130018 [details] [diff] [review] Proposed patch a=asa (on behalf of drivers) for checkin to the Mozilla 1.5 branch. Please add the fixed1.5 keyword when this is landed on the branch. Thanks.
Attachment #130018 - Flags: approval1.5? → approval1.5+
Fix checked into the trunk and 1.5 branch.
Status: NEW → RESOLVED
Closed: 22 years ago
Keywords: fixed1.5
Resolution: --- → FIXED
Comment on attachment 130018 [details] [diff] [review] Proposed patch a=mkaply for 1.4.2
Attachment #130018 - Flags: approval1.4.2? → approval1.4.2+
Keywords: fixed1.4.2
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: