216588 - Remove GOTOs from nsMsgUtils.cpp

Status: RESOLVED WONTFIX

(MailNews Core :: Composition, defect)

Description

[Matthias Bockelkamp]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030812
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030812

Remove GOTOs from nsMsgUtils.cpp

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Matthias Bockelkamp]

Attachment: Patch v1

Comment 2

[Matthias Versen [:Matti]]

Comment on attachment 130017 [details] [diff] [review]
Patch v1

You can't request a SR from neil. Please look at the SR list first

Comment 3

[[e-mail]]

No. Don't do this. You've just increased codesize and reduced readability, and
for what? the goto's were perfectly happy the way they were.

If you really want to kill them, then do something like this instead.

while(1) // or, |for (;;)|
{
  ....
        continue; // used to be |goto AGAIN;|
  ....
        continue; // used to be |goto AGAIN;|
  ....
  break;
}

but, why on earth bother?

Comment 4

[Matthias Bockelkamp]

The problem I have with GOTOs is that you have to look for the calls, instead of
just looking for the matching } in a "normal" loop. I knew this would increasee
the code size, but I think it's only a few bytes. If you wish to keep the GOTOs,
then one could perhaps do this:

AGAIN: //called from Lines x and y

This would be bad if the file is modified, because updating the line numbers
will be forgotten. So perhaps this way:

AGAIN: //called from two places
...
//no more calls to AGAIN from here on

This would also speed up reading the code.

Comment 5

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 6

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 7

[Matthias Bockelkamp]

Let's resolve this old monster. WONTFIX.