216638 - Remove "Don't ask me again" checkbox for warning about launching executable

Status: VERIFIED WONTFIX

(Toolkit :: Downloads API, enhancement)

Description

[Brian 'netdragon' Bober]

I really don't believe we should give people the option to disable the warning
on something of this magnitude. Often times, people share computers with others
and even if they know better, their friend might not. Perhaps they might forget,
also, or not realize the file is an executable type.

If people really know what they are doing, they can set the hidden pref, but I
don't believe we should have that option available.

Comment 1

[Brian 'netdragon' Bober]

http://lxr.mozilla.org/seamonkey/source/embedding/components/ui/progressDlg/locale/en-US/nsProgressDialog.properties#40

Comment 2

[Brian 'netdragon' Bober]

var dontaskmsg = strBundle.getString("dontAskAgain");
var checkbox = {value:0};
var okToProceed = promptService.confirmCheck(window, title, msg, dontaskmsg,
checkbox);

http://lxr.mozilla.org/seamonkey/source/xpfe/components/download-manager/resources/downloadmanager.js#234

http://lxr.mozilla.org/seamonkey/source/embedding/components/ui/progressDlg/nsProgressDialog.js#491

Comment 3

[Brian 'netdragon' Bober]

Attachment: The patch.

People will download .exe so infrequently that this message isn't like other
security warnings like entries in forms. It won't hurt to show it each time,
and if they really want to get rid of it, they can do it through about:config.

Comment 4

[Brian 'netdragon' Bober]

Attachment: Patch with an additional comment

This patch is the same, but includes a comment mentioning why there is no
checkbox.

Comment 5

[Brian 'netdragon' Bober]

This will affect Mozilla Seamonkey, also.

Comment 6

[Brian 'netdragon' Bober]

Attachment: The last patch

Neil noticed some issues with the patch. I needed to remove a value from
nsProgressDialog.properties, and use confirm, not confirmcheck.

I also made Cancel the default choice so people trigger happy on their space
key and mouse buttons don't accidentally launch an executable.

Comment 7

[Brian 'netdragon' Bober]

Attachment: Truly the last patch

A line wasn't properly indented.

Comment 8

[Brian 'netdragon' Bober]

Attachment: The last patch again

Neil just told me that hitting cancel activates the second button, which would
be OK in this case. Therefore, I changed it back to confirm instead of
confirmEx.

The default button on OK CANCEL dialogs should be Cancel or at least you should
be able to choose!

:-(

Comment 9

[Mike Connor [:mconnor]]

Repetitive dialogs are annoying and will be ignored after a while.

-> ben, WONTFIX?

Comment 10

[Brian 'netdragon' Bober]

Then could we at least make this a bit harder to turn off or give a warning that
if you turn this off, other users could unknowingly run excecutable files?

Comment 11

[Mike Connor [:mconnor]]

we don't even ask anymore.

Comment 12

[Andreas Kunz]

Comment on attachment 130052 [details] [diff] [review]
The last patch again

Bug is wontfix, removing review requests.