216908 - MacOS X builds are incorrectly linked against libiconv if it's present.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jerry Talkington]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030821 Mozilla Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5b) Gecko/20030821 Mozilla Firebird/0.6.1+

If a user has libiconv installed (which is everybody using fink), it is linked
regardless of the --enable-native-uconv switch (if it is enabled, the build
fails.)  It's not a standard OS X library,  so it makes the build usable only on
machines with fink installed.

Reproducible: Always

Steps to Reproduce:
1. Build on MacOS X with fink installed.
2.
3.



Expected Results:  
Searching for libiconv is disabled on Windows machines, so that there is no
dependency on the cygwin et. al. libraries.  This should probably be done for
MacOS X also.

Here is the one line patch that fixes it:

Index: configure.in
===================================================================
RCS file: /usr/local/cvsroot/mozilla/configure.in,v
retrieving revision 1.1271
diff -u -r1.1271 configure.in
--- configure.in        18 Aug 2003 18:56:42 -0000      1.1271
+++ configure.in        21 Aug 2003 03:05:40 -0000
@@ -2271,7 +2271,7 @@
 fi

 case $target_os in
-    os2*|msvc*|mks*|cygwin*|mingw*)
+    os2*|msvc*|mks*|cygwin*|mingw*|darwin*)
         ;;
     *)

Comment 1

[Jerry Talkington]

Attachment: Adds darwin to the list of $target_os' that are not checked libiconv

Comment 2

[Darin Fisher]

Comment on attachment 130190 [details] [diff] [review]
Adds darwin to the list of $target_os' that are not checked libiconv

i'll sr= this.	it is most certainly what we want.  nsLocalFileOSX doesn't even
use iconv (nsLocalFileUnix is _the_ iconv consumer in the Mozilla codebase).

Comment 3

[cls]

Comment on attachment 130190 [details] [diff] [review]
Adds darwin to the list of $target_os' that are not checked libiconv

Turn off unneeded iconv detection for darwin/OSX builds. Removes fink
dependency from builds. Low risk.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 130190 [details] [diff] [review]
Adds darwin to the list of $target_os' that are not checked libiconv

a=asa (on behalf of drivers) for checkin to 1.5beta

Comment 5

[cls]

The patch has been checked in.