216920 - Enhancements to OS/2 D&D code - Phase II

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Rich Walsh]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5b) Gecko/20030813
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.5b) Gecko/20030813

My previous submission [Bug 210321] focused on drags from Mozilla into
the native environment.  The attached patch complements those enhancements
by focusing primarily on drops into Mozilla.

[Enhancements]

-- All targets within Mozilla which accept URLs or text are now enabled
for native drags (provided the item is in a supported format).
-- Added support for dropping text into edit windows;  supported formats
are URLs, filenames, the contents of files (Alt-drop), and DragText.
-- Eliminated all video corruption during drag & drop (with one exception
noted below).  For drags from Mozilla, all while-you-drag features are
fully enabled and corruption-free.  For native drags, popups & scolling
are suppressed but cursor movement within edit windows remains enabled.
-- Implemented NS_DRAGDROP_ENTER event.

[Bug Fixes & Other Changes]

-- Fixed a bug in my previous submission which caused attempts to render
non-file-based URLs to fail (e.g. "mailto:"),
-- Eliminated minor errors that generated compiler warnings in functions
I modified (e.g. replaced NULL with 0 where an integer was called for).

[Bugs & Shortcomings]

-- Video corruption still occurs in one instance:  if the Bookmarks menu
has never been displayed and a native drag hovers over the Bookmark
button or menu item, the pointer/icon image will remain when it moves on.
-- Although video scrolling is suppressed during native drags, logical
scrolling still occurs.  This could result in misdirected drops.  Once
the drag concludes, the display is updated correctly.

[Files Changed]

-- nsWindow (.cpp & .h)
-- nsDragService (.cpp & .h)


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Rich Walsh]

Attachment: patch to implement d&d enhancements on OS/2

Comment 2

[Rich Walsh]

Attachment: new/modified code after patch has been applied

This should be a lot easier to read than the diff.  Each section
clearly identifies the nature and/or purpose of the additions or
modifications.

Comment 3

[Matthias Versen [:Matti]]

NEW

Comment 4

[Mike Kaply [:mkaply]]

Can ReleaseDragPS be named something different? or return something differently?

IT seems odd that if ReleaseDragPS succeeds (is TRUE), then we have to free the
regular HPS.

It should probably be "try ReleaseDragPS" and if that fails, then do something.

Just a thought.

Comment 5

[Mike Kaply [:mkaply]]

*** Bug 216522 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Kaply [:mkaply]]

*** Bug 216996 has been marked as a duplicate of this bug. ***

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 130195 [details] [diff] [review]
patch to implement d&d enhancements on OS/2

r=mkaply, sr=blizzard (platform specific)
a=mkaply

I might clean this up a little later, but it looks good.

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in to trunk

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 130195 [details] [diff] [review]
patch to implement d&d enhancements on OS/2

Not going to get for 1.4.1