217080 - v1.41 branch: rendering mailto: URLs via D&D fails

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Rich Walsh]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.4) Gecko/20030624

Code that I submitted as part of Bug 210321 contains an error in
nsDragService which causes attempts to render non-file-based URLs
to fail (e.g. "mailto:").  Further, if the user requests Mozilla
to render the "file" to which this URL refers, both Mozilla and
the target application will crash.

This is caused by the incorrect use of the nsIURL interface and
the failure to check whether an interface pointer was actually
returned before using it.

The attached patch fixes this.  It always uses the more generic
nsIURI interface when rendering URLs.  Further, it leverages the
failure of nsIURL to determine whether it should honor a request
to render the file reference.  If nsIURL fails, it renders the
URL instead.  And of course, the new code performs all appropriate
error checking.

Note:  The attached patch is targeted at the 1.41 branch.  This
fix is already part of Bug 216920 which is targeted at the trunk.


Reproducible: Always

Steps to Reproduce:
1. Drag any mailto: URL to the Desktop and drop it.
or
2. Drag any mailto: URL to the Desktop and Ctrl-drop it.


Actual Results:  
1. No URL object is created.
or
2. Mozilla crashes;  the WPS may crash as well.

Expected Results:  
1. A URL object should have been created.
or
2. Either the operation should fail gracefully,
   or preferably, a URL object should be created.

For scenario #2 above, Mozilla traps in WDGTOS2.DLL at 0001:00010649;
PMSHELL traps in PMCTLS.DLL at 0002:000b922b.

Comment 1

[Rich Walsh]

Attachment: patch to fix bug in nsWindow

Comment 2

[Rich Walsh]

Attachment: modified code after patch has been applied

Comment 3

[Matthias Versen [:Matti]]

-> Reporter

Comment 4

[Mike Kaply [:mkaply]]

Rich, my plan is to put your 216920 patch on the branch as well...

Comment 5

[Mike Kaply [:mkaply]]

I put this patch on the branch since 216920 is not there and won't be for 1.4.1.