21715 - nsJSInstall doesn't SaveError() when errors detected

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Daniel Veditz [:dveditz]]

nsJSInstall does some basic error checks on method arguments and returns errors
to the script, but does not call nsInstall::SaveError() so these can be
detected later.

This mostly affects type checking for the new folder object, but in a few other
cases too.

We may need to make SaveError() public in order to call it.

Comment 1

[dbragg]

Fix is in hand.  Not an M12 bug so can't check in until the tree opens.

Comment 2

[dbragg]

Fixed by adding SaveError to the nsJSInstall.cpp code.

Comment 3

[Jimmy Lee]

Build 2000-01-10-09-M13(WIN), 2000-01-13-14-M13(MAC), 2000-01-13-13-M13(LINUX)

Errors are being trapped.  Marking Verified!