21728 - URLs load multiple times

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[Warren Harris]

I was trying to get some bloat/leak stats by selecting the menu item QA ->
Bloat: Dump New Stats. What I found is that the about:bloat URL is loaded 3
times! This originates from the following menuitem in navigatorOverlay.xul:

      <menuitem value="&BloatDumpNewCmd.label;"
oncommand="window.content.location.href='about:bloat?new'"/>

I'll enclose the stack crawls. The first two stacks look identical and
originate from the SetLocationProperty js call. I would guess this is a
widget bug. The third comes from nsDocumentOpenInfo::OnStartRequest which calls
nsDocumentOpenInfo::DispatchContent -- this could be a url dispatching bug. So
maybe there are 2 bugs here.

There's a third bug which is that after creating 3 bloat log files, the wrong
file ends up being displayed in the end. I'll report that bug separately.

I tried it again selecting the QA -> Bug Writing menu item -- same sort of idea
-- but this one only got loaded twice. Those stacks look like the second and
third ones from the about:bloat case which I would guess to be a url
dispatching bug.

I think fixing this is important since it may induce other problems with normal
browser operation.

This was all done with this morning's build: 12/14/99.

Comment 1

[Warren Harris]

Attachment: stack crawls for two cases

Comment 2

[Peter Trudelle]

Why was this assigned to XPToolkit?  Other menus items are handled once, so it
is more likely that this is an URL dispatching problem, as warren mentions.
reassigning to mscott.

Comment 3

[Warren Harris]

I assigned this to toolkit because I think the first bug is with the menuitem
tag. It seems to be doing the same work twice.

But mscott needs to look at this too, because there seems to be something
broken in the url dispatcher causing the third load.

Comment 4

[Warren Harris]

Ok, I see now that this is entirely a URL dispatching problem. The problem is
that nsWebShell.cpp line 1698 in nsWebShell::DoLoadURL it calls NS_OpenURI, and
then in the same function at line 1783 calls LoadDocument if aKickOffLoad is
true (and it defaults to true when called from nsWebShell::LoadURI line 1956).

Mscott's comment on this checkin was:

Bug #14928 --> phase one of uri dispatching landing. webshell is a
nsIURIContent Listener. r=travis.

Changing summary to: URLs load multiple times
from menuitems load URLs multiple times

I'm not sure what we want to do with this except verify it with the new
webshell stuff. Cc'ing travis.

Comment 5

[Phil Peterson]

Seems like a beta stopper

Comment 6

[Scott MacGregor]

The url was not actually being loaded multiple times as in we weren't actually
requesting the document multiple times. But it was true that DoLoadURL gets
called twice when you load some urls (if the url got dispatched to this webshell
it was only called once). The extra call is necessary until we're done gutting
the doc loader and webshell.


I just wanted to clarify that we aren't physically trying to open the url more
than once. The NS_OpenURI method in there that warren was referring to only
applies to urls that are references to the current document loaded into the
webshell (i.e. with a #fooo) and we only call this once and kick out of the uri
load in this case.

Comment 7

[Scott MacGregor]

I added protocection in nsWebshell::DoContent so we only call DoLoadURL once per
webshell per url. Marking as fixed.

Comment 8

[Paul MacQuiddy]

I can't verify this w/o a debug build, warren can you look at this and mark it
verified? Thanks.

Comment 9

[shrirang khanzode]

sorry for the spam, changing QA contact.

Comment 10

[Paul Wyskoczka]

Updating QA Contact

Comment 11

[Michael Dunn]

verified as changed in source