Closed
Bug 217409
Opened 21 years ago
Closed 21 years ago
Password manager should have empty master password by default
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firebird0.7
People
(Reporter: bugzilla, Assigned: bryner)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
brendan
:
review+
cls
:
superreview-
|
Details | Diff | Splinter Review |
Reporter | ||
Updated•21 years ago
|
Target Milestone: --- → Firebird0.7
Comment 1•21 years ago
|
||
You mean the password manager should not prompt to choose a master password? This would disable the master password without having a UI to enable it. In that case we need a UI to choose/edit/remove a master password. Bug 216539 asks for that.
Assignee | ||
Comment 2•21 years ago
|
||
checked in a change to initialize the master password to an empty string when password manager needs to encrypt or decrypt and the user has not set a password.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 3•21 years ago
|
||
When building today I came across this error twice. First time I thought my tree was borked so I pulled it fresh, and same error again. I'm building on VS.NET. I'm pretty sure it has to do with this bug ... because I built early AM on 8/27 without problems. Here is the console output: make[5]: Entering directory `/cygdrive/d/cvs-1.11.5/mozilla/toolkit/components/ asswordmgr' make[6]: Entering directory `/cygdrive/d/cvs-1.11.5/mozilla/toolkit/components/ asswordmgr/base' nsPasswordManager.cpp Building deps for nsPasswordManager.cpp /cygdrive/d/cvs-1.11.5/mozilla/build/cygwin-wrapper cl -FonsPasswordManager.obj -c -D_IMPL_NS_GFX -D_IMPL_NS_MSG_BASE -D_IMPL_NS_PICS -D_IMPL_NS_WIDGET -DOSTY E=\"WINNT5.1\" -DOSARCH=\"WINNT\" -I../../../../dist/include/necko -I../../../ ./dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/inclu e/windowwatcher -I../../../../dist/include/layout -I../../../../dist/include/ur loader -I../../../../dist/include/pref -I../../../../dist/include/intl -I../../ ./../dist/include/dom -I../../../../dist/include/content -I../../../../dist/inc ude/widget -I../../../../dist/include/autocomplete -I../../../../dist/include/p pnss -I../../../../dist/include/passwordmgr -I../../../../dist/include -I../../ ./../dist/include/nspr -TP -nologo -W3 -nologo -Gy -Fdpasswordmgr_s.pd -DNDEBUG -DTRIMMED -O1 -G7 -MD -DX_DISPLAY_MISSING=1 -DHAVE_SNPRIN F=1 -D_WINDOWS=1 -D_WIN32=1 -DWIN32=1 -DXP_WIN=1 -DXP_WIN32=1 -DHW_THREADS=1 -D INVER=0x400 -DSTDC_HEADERS=1 -DWIN32_LEAN_AND_MEAN=1 -DNO_X11=1 -D_X86_=1 -DD_I O=d_ino -DMOZ_DEFAULT_TOOLKIT=\"windows\" -DMOZ_PHOENIX=1 -DMOZ_XUL_APP=1 -DOJI 1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1 -DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSL ADER=1 -DMOZ_MATHML=1 -DMOZ_LOGGING=1 -DMOZ_USER_DIR=\"Mozilla\" -DMOZ_XUL=1 -D OZ_PROFILELOCKING=1 -DMOZ_DLL_SUFFIX=\".dll\" -DJS_THREADSAFE=1 -DNS_PRINT_PREV EW=1 -DNS_PRINTING=1 -DMOZILLA_VERSION=\"1.5b\" -D_MOZILLA_CONFIG_H_ -DMOZILLA CLIENT /cygdrive/d/cvs-1.11.5/mozilla/toolkit/components/passwordmgr/base/nsPas wordManager.cpp nsPasswordManager.cpp d:/cvs-1.11.5\mozilla\toolkit\components\passwordmgr\base\nsPasswordManager.cpp 72) : fatal error C1083: Cannot open include file: 'nsIPK11TokenDB.h': No such ile or directory make[6]: *** [nsPasswordManager.obj] Error 2 make[6]: Leaving directory `/cygdrive/d/cvs-1.11.5/mozilla/toolkit/components/p sswordmgr/base' make[5]: *** [libs] Error 2 make[5]: Leaving directory `/cygdrive/d/cvs-1.11.5/mozilla/toolkit/components/p sswordmgr' make[4]: *** [libs] Error 2 make[4]: Leaving directory `/cygdrive/d/cvs-1.11.5/mozilla/toolkit/components' make[3]: *** [libs] Error 2 make[3]: Leaving directory `/cygdrive/d/cvs-1.11.5/mozilla/toolkit' make[2]: *** [tier_50] Error 2 make[2]: Leaving directory `/cygdrive/d/cvs-1.11.5/mozilla' make[1]: *** [default] Error 2 make[1]: Leaving directory `/cygdrive/d/cvs-1.11.5/mozilla' make: *** [build] Error 2
Comment 5•21 years ago
|
||
At least one other person has confirmed this via the MZ Forums. See this thread: http://forums.mozillazine.org/viewtopic.php?t=22090
Comment 6•21 years ago
|
||
Verify and found a 'workaround' on linux build: Sorry, am kind of short on time, but took a quick look at this and it seems the master-makefile isn't going here: ~./mozilla/security/manager/ssl/public and doing a make; make export; (which appears to take care of the 'invisible' *PK11*.h files) Yek
Assignee | ||
Comment 7•21 years ago
|
||
--enable-crypto is a required option to build Firebird now. Make sure you have it in your mozconfig.
Comment 8•21 years ago
|
||
This is failing for me on MacOS X also. Here is my .mozconfig: export MOZ_PHOENIX=1 mk_add_options MOZ_PHOENIX=1 export MOZILLA_OFFICIAL=1 mk_add_options MOZILLA_OFFICIAL=1 export BUILD_OFFICIAL=1 mk_add_options BUILD_OFFICIAL=1 mk_add_options MOZ_MAKE_FLAGS=-j2 ac_add_options --enable-crypto ac_add_options --disable-tests ac_add_options --disable-debug ac_add_options --disable-mailnews ac_add_options --disable-composer ac_add_options --enable-pthreads ac_add_options --enable-strip ac_add_options --enable-optimize ac_add_options --disable-ldap ac_add_options --disable-mailnews ac_add_options --disable-calendar ac_add_options --enable-extensions=cookie,wallet,xml-rpc,xmlextras,p3p,pref,tran sformiix,universalchardet,typeaheadfind,webservices
Comment 9•21 years ago
|
||
For me what is the real kicker here is that it works on one build machine and not another. 100% identical build environment (software wise they're the same, though one machine is faster than the other P4-2.53GHz (fails) vs P4-1.7GHz (works)), and 100% identical .mozconfig, which I've shown below: export MOZ_PHOENIX=1 mk_add_options MOZ_PHOENIX=1 ac_add_options --enable-crypto ac_add_options --disable-tests ac_add_options --disable-debug ac_add_options --disable-mailnews ac_add_options --disable-composer ac_add_options --enable-optimize="-O1 -G7" ac_add_options --disable-ldap ac_add_options --enable-extensions=cookie,xml-rpc,xmlextras,p3p,pref,transformiix,universalchardet,typeaheadfind,webservices ac_add_options --enable-static ac_add_options --disable-shared ac_add_options --disable-profilesharing ac_add_options --disable-installer I can't imagine why it would work on one machine okay and not the other. Both were clobber builds, both were checked out at the same time. Yet, one failed, the other worked. I didn't want to say that right at the start when I reported my problem because people would have thought I was crazy and I had screwed up on the machine that was failing with this error. But now that a few people have confirmed at least I'll be taken seriously. :) Some more people have verified via the MZ forum link I posted before.
Assignee | ||
Comment 10•21 years ago
|
||
The build problem is that I created a build ordering discrepency between security and toolkit. So, this will work fine on a depend build but fail on a clobber build.
Assignee | ||
Comment 11•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Attachment #130583 -
Flags: review?(cls)
Comment 12•21 years ago
|
||
> Created an attachment (id=130583)
> move psm before toolkit
This patch fixes everything. My build completes and the binaries work fine.
Thanks, and hope it gets reviewed and checked in soon.
Comment 13•21 years ago
|
||
Also, on the machine that was working as per my previous comment, I deleted the tree and re-pulled it completely and it failed without the patch. The patch fixed it on that one too. So basically the bug is now consistent on my end. And the patch consistently fixes it. I had meant to include this in my last comment, but I forgot. Sorry for the bugspam.
Comment 14•21 years ago
|
||
Although the patch works fine (using this command line in linux): "patch -p1 ~./Makefile.in < ../brynersPatch" (where "brynersPatch is a saved text file of his attachment) line 8 of the patch throws this info/warning message: "missing header for unified diff at line 8 of patch" Line 8 is "@@ -42,6 +42,9 @@ default: $(SUBMAKEFILES)", And then it goes along and patches Makefile.in without another problem and the build works.
Comment 15•21 years ago
|
||
Comment on attachment 130583 [details] [diff] [review] move psm before toolkit Looks ok to me. /be
Attachment #130583 -
Flags: review?(cls) → review+
Comment 16•21 years ago
|
||
Comment on attachment 130583 [details] [diff] [review] move psm before toolkit a=asa (on behalf of drivers) for checkin to 1.5.
Comment 17•21 years ago
|
||
Comment on attachment 130583 [details] [diff] [review] move psm before toolkit When you move psm into tier_40, you still need to make sure that the directories are listed in the proper order when you add them to DIRS. Otherwise, running 'make export && make libs' will have a different build order than 'make'.
Attachment #130583 -
Flags: superreview-
Assignee | ||
Comment 19•21 years ago
|
||
Checked in, with cls's comment addressed.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
Comment 20•21 years ago
|
||
*** Bug 217977 has been marked as a duplicate of this bug. ***
Comment 22•19 years ago
|
||
This bug introduced a dependnecy of the toolkit on crypto. Since there are some countries where crypto is illegal, this dependency should be removed.
Depends on: 227792
You need to log in
before you can comment on or make changes to this bug.
Description
•