217432 - finger/datetime channel always return failure on suspend/resume

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

124 NS_IMETHODIMP
125 nsDateTimeChannel::Suspend()
126 {
127     if (mPump)
128         mPump->Suspend();
129     return NS_ERROR_UNEXPECTED;
130 }
131 
132 NS_IMETHODIMP
133 nsDateTimeChannel::Resume()
134 {
135     if (mPump)
136         mPump->Resume();
137     return NS_ERROR_UNEXPECTED;
138 }

(finger channel does the same)

Shouldn't the mPump-> calls look like |return mPump->Suspend();|?

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 130456 [details] [diff] [review]
patch

sr=bzbarsky

Comment 3

[Darin Fisher]

Comment on attachment 130456 [details] [diff] [review]
patch

sr=darin (doh!)

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in datetime/nsDateTimeChannel.cpp;
/cvsroot/mozilla/extensions/datetime/nsDateTimeChannel.cpp,v  <--  nsDateTimeCha
nnel.cpp
new revision: 1.32; previous revision: 1.31
done
Checking in finger/nsFingerChannel.cpp;
/cvsroot/mozilla/extensions/finger/nsFingerChannel.cpp,v  <--  nsFingerChannel.c
pp
new revision: 1.45; previous revision: 1.44
done