Closed Bug 217528 Opened 21 years ago Closed 17 years ago

'Move Manually-Marked Junk to Junk Folder' does nothing when 'Move Detected Junk' is turned off

Categories

(MailNews Core :: Backend, defect)

Product:
MailNews Core
Component:
Backend
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ewong, Unassigned)

References

(Depends on 1 open bug)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030718
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030718

With junk mail controls enabled, if I check "Move incoming messages to
junk mail folder" and then I check "When I manually Mark messages as
junk" and select the "Move to Junk Folder", then when I uncheck the
"Move incoming messages", the "Move to junk folder" radio control is
disabled (greyed out) BUT the Delete radio button is still enabled.
It allows me to select the Delete Radio button, but does not permit
me to change back to "Move to Junk Folder" until I re-check the
"Move incoming messages to.." checkbox.



Reproducible: Always

Steps to Reproduce:
1. Select "Enable junk mail controls"
2. Check "Move incoming messages determined to be junk mail to:"
3. Select "Junk" folder on:  radio button
4. Check "When I manually mark messages as Junk:"
5. Select "Move to junk folder"
6. Uncheck "Move incoming messages determined to be junk mail to:"


Actual Results:  
The subparts within the "Move incoming messages determined to be junk mail to:"
are all disabled.  

For the "When I manually mark messages as Junk:" part, only the "Move to Junk
Folder" radio is disabled.  The Delete radio isn't.  



Expected Results:  
Either ALL of the "When I manually mark messages as Junk:" sub parts ("Move to
Junk folder" and "Delete") be disabled, or they should all be enabled.  

My expectation would be that this subpart should be independent of the "Move
Incoming messages determined to be junk mail to:" part.
Addendum:  

With the "Move incoming mail determined to be junk mail to:" unchecked,
and the "Move to junk folder" disabled, when you go to the actual account's
inbox and select an email as junk, nothing happens.  So the "Move
to junk folder" is truly disabled (but by that merit, it should also be
fixed to moving the selected junk mail to the Junk folder, which it doesn't
do.)  

So, in this situation, the junk mail is defaulted (by merit of the
fixed setting of "Move to Junk folder") to be thrown into the Junk 
folder, but it doesn't because it's disabled.  It's a little confusing.


Confirming.  The bug here covers a weird combo of selection and unselection.

When "Move..." is checked, then "...manually..." is checked, then "Move..." is
unchecked, the two radio buttons of "...manually..." have different disabled
states.  This seems to be designed (partly) because the special Junk folder is
only created when the "Move..." checkbox and first radiobutton are active. 
(pause for breath)

If the "...manually..." checkbox's first radiobutton becomes selected but
disabled, then manually marked junk mail will not be moved to a Junk folder even
if one exists.  The correct behavior should probably be to allow that
radiobutton to be enabled based on the existence of a special junk folder, not
on the checked state of the higher "Move..." checkbox.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Bug 221415 is this same problem, files as a Thunderbird bug.
Depending on TB bug since new changes should go into TB first.

Also this should be "mail window front end" not "filters"...
Depends on: 221415
*** Bug 230110 has been marked as a duplicate of this bug. ***
*** Bug 218619 has been marked as a duplicate of this bug. ***
No longer depends on: 221415
*** Bug 221415 has been marked as a duplicate of this bug. ***
bug 233281 has a patch. 

*** This bug has been marked as a duplicate of 233281 ***
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
Reopening. Bug 233281 is about Thunderbird, this bug about MailNews. They may or
may not be fixed together since the code in question is actually forked. Also I
don't think the patch in bug 233281 is correct.

Seth: It seems you implemented this behaviour by purpose. See bug 194273 comment
36. Do you remember why you did this?
Status: RESOLVED → REOPENED
OS: Windows 2000 → All
Resolution: DUPLICATE → ---
*** Bug 245866 has been marked as a duplicate of this bug. ***
Product: MailNews → Core
Note that bug 233281, the alleged dupe from comment 8, has been patched.
Could be backported here, maybe?

Moving this out of Core to AppSuite.
Status: REOPENED → NEW
Component: MailNews: Filters → MailNews: Main Mail Window
Product: Core → Mozilla Application Suite
QA Contact: laurel
Assignee: sspitzer → mail
seems this was resolved in 1.7.12
(In reply to comment #12)
> seems this was resolved in 1.7.12

I don't think so; I see the symptom as reported in Moz 1.7.12, 
Seamonkey 1.0a-0910, 1.1a-1030, Win2K.
Severity: normal → minor
Thunderbird bug for this issue is Bug 268101.
Oh, sorry. It is really still there. Imho the best way to fix it would be moving junk mail folder setting as separate option, probably to "Mail and Newsgroup account settings"/"Copies and folders" (but although with option "enable junk mail controls", because of bug 197864)

Here's a simpler description:

"Manually mark messages as Junk":
The option "Move to Junk" does not work when "Move incoming messages determined to be junk is unchecked"

Expected result:
With "Manually mark messages as Junk" - "Move to Junk" enabled 
pressing the "Junk" button should ALWAYS move the message to the Junk-folder.
(In reply to comment #16)
> Here's a simpler description:
> 
> "Manually mark messages as Junk":
> The option "Move to Junk" does not work when "Move incoming messages
> determined to be junk is unchecked"

This gets to the core of what's really the problem here, and it is still true with the new organization of the junk controls (bug 257990, coming in TB 2.0).  The difference with the new dialogs is that the Manually Move controls -- which appear in the Options dialog -- are never disabled (and the one setting applies to all accounts).

Note that it's possible to disable junk detection for an account and still have the Move Detected Junk setting turned on, which in turn enables operation of 
the Move-on-Manual-Mark action.


(In reply to comment #14)
> Thunderbird bug for this issue is Bug 268101.

It's not exactly the same: that bug notes that the junk folder is not created unless the Move Detected Junk option is selected.  I'm marking this bug as dependent on that one (and moving both to Core).


From bug 230110 comment 3 by David Nicol (duped to this bug):
> I want to configure thunderbird to show me suspected junk but take away
> confirmed junk.  That configuration does not seem possible at this build.

That's why this bug is an issue.  However, as a workaround, if 'Delete' is selected as the manual-mark action, that will work even if the 'Move detected junk' setting is turned off (in TB 1.5 as well).

This bug may be a little more visible once 2.0 is released, since the handling of manual-mark is now a global option, but multiple accounts can have independent move-detected-junk settings.  If the global setting is Move, 
marking a message as Junk only moves them for accounts that automatically move junk; if the global setting is Deleted, marking a message as Junk deletes in 
all accounts.
Component: MailNews: Main Mail Window → MailNews: Backend
Depends on: 268101
Product: Mozilla Application Suite → Core
Summary: Manually mark messages as Junk / Move to Junk disabled but Delete is enabled when Move incoming messages determined to be junk is unchecked → 'Move Manually-Marked Junk to Junk Folder' does nothing when 'Move Detected Junk' is turned off
I no longer see the option for how to handle mail manually marked as Junk.  Where is that option setting now located in the UI?


(In reply to comment #18)
> I no longer see the option for how to handle mail manually marked as Junk. 
> Where is that option setting now located in the UI?
> 

Sorry, to clarify, I am using Seamonkey 1.1.2006-06-04:

SeaMonkey 1.1a

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1a3) Gecko/20060604 SeaMonkey/1.1a

(In reply to comment #19)
> (In reply to comment #18)
> > I no longer see the option for how to handle mail manually marked as Junk. 
> > Where is that option setting now located in the UI?
> > 
> 
> Sorry, to clarify, I am using Seamonkey 1.1.2006-06-04:
> 
> SeaMonkey 1.1a
> 
> Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1a3) Gecko/20060604
> SeaMonkey/1.1a
> 

OK, I think I found why I no longer see in the UI an option for how to handle mail manually marked as Junk:  Bug 335846.
*** Bug 362592 has been marked as a duplicate of this bug. ***
I find it hard to believe that this bug exists for over 3 years now, and it hasn't been fixed yet... Isn't it about time?
Someone should finally split setting of junk folder and settings of what to do with messzages marked as junk, automatically or manually. I wonder why it wasn't done in SeaMonkey 1.1...

Can this bug be closed as DUP of FIXED Bug 279018 ? 
This is not fixed in SeaMonkey 1.1.4. There are _some_ Junk controls in global menu, but "move new junk messages" is only in per-account menu, the setting of junk folder still depends on this and moving of manually marked messages doesn't work if it's unset.
(In reply to comment #25)
> This is not fixed in SeaMonkey 1.1.4.

Patch for Bug 279018 is applied to trunk only, is not applied to 1.8.1 branch yet.
Can you re-produce problem with Seamonkey latest-trunk build?

Note:
Latest-trunk will try to migrate current profile your Sm 1.1.4 is using, if  profile or kick of profile manager is not requested at start up.
I recommend you to test with "seamonkey.exe -P" and new profile for future Sm 3.0, in order to avoid unwanted problems due to migrated profile.
e.g. If trunk with migrated profile runs, mail is downloaded from POP3 server, then the downloaded mails can't be downloaded to current profile for Sm 1.1.4.
This is trouble I really experienced while testing.  
Sorry for not noticing.
I wasn't able to run last 3 trunk builds on windows, If noone will confirm/deny this, I'll retry later
This feature works in trunk build 2007082803, however:

1. setting of junk folder still requires having automatic moving of junk messages turned on (if I turn it off, it remembers the junk folder setting and moves manually marked messages where expected)
2. moving of manually marked junk messages is set in Preferences, while automatic moving is set in mail/news account settings, which I found a bit unlogical - first is global setting, the latter is per-account setting.

Technically, this bug is solved, however issues above make me think it should be tweaked a bit.
->WFM per comment 28. Feel free to reopen if you can reproduce with a recent trunk build.
Status: NEW → RESOLVED
Closed: 20 years ago → 17 years ago
Resolution: --- → WORKSFORME
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.