217906 - ###!!! ASSERTION: null args: 'aNode1 && aNode2 && aResult', file i:/build/mozilla/editor/libeditor/html/nsHTMLEditRules.cpp, line 7556

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[timeless]

viewer, cvs debug build from mid last week. i was playing w/ edit mode. i've hit
a bunch of other assertions already. this is my first editor assert.

###!!! ASSERTION: null args: 'aNode1 && aNode2 && aResult', file
i:/build/mozilla/editor/libeditor/html/nsHTMLEditRules.cpp, line 7556
Break: at file i:/build/mozilla/editor/libeditor/html/nsHTMLEditRules.cpp, line 7556

(yes localhost, sorry. it's aolserver in case people are curious).
steps: run viewer, load localhost select table stuff, flip to edit mode, press
delete.

+	aNode1	0x00000000
+	aNode2	0x0817890c
+	aResult	0x0012ed88
+	this	0x0811dc80

nsHTMLEditRules::InDifferentTableElements(nsIDOMNode * 0x00000000, nsIDOMNode *
0x0817890c, int * 0x0012ed88) line 7556 + 44 bytes

	aAction	2
+	leftNode	{0x00000000}
+	leftParent	{0x00000000}
	nsIEditor::ePrevious	2
+	rightNode	{0x0817890c}
+	rightParent	{0x00000000}
+	this	0x0811dc80

nsHTMLEditRules::WillDeleteSelection(nsISelection * 0x081617a0, short 2, int *
0x0012ef28, int * 0x0012ef64) line 2175 + 42 bytes
nsHTMLEditRules::WillDoAction(nsHTMLEditRules * const 0x0811dc84, nsISelection *
0x081617a0, nsRulesInfo * 0x0012ef2c, int * 0x0012ef28, int * 0x0012ef64) line
591 + 31 bytes
nsPlaintextEditor::DeleteSelection(nsPlaintextEditor * const 0x080a5080, short
2) line 863 + 59 bytes
nsTextEditorKeyListener::KeyPress(nsTextEditorKeyListener * const 0x0811c7d0,
nsIDOMEvent * 0x05eb4d14) line 203
nsEventListenerManager::HandleEvent(nsEventListenerManager * const 0x08161140,
nsIPresContext * 0x0815bdf0, nsEvent * 0x0012f9ec, nsIDOMEvent * * 0x0012f680,
nsIDOMEventTarget * 0x08155dd4, unsigned int 514, nsEventStatus * 0x0012f818)
line 1634 + 41 bytes
nsDocument::HandleDOMEvent(nsDocument * const 0x08155da0, nsIPresContext *
0x0815bdf0, nsEvent * 0x0012f9ec, nsIDOMEvent * * 0x0012f680, unsigned int 514,
nsEventStatus * 0x0012f818) line 3806
nsGenericElement::HandleDOMEvent(nsGenericElement * const 0x08157430,
nsIPresContext * 0x0815bdf0, nsEvent * 0x0012f9ec, nsIDOMEvent * * 0x0012f680,
unsigned int 519, nsEventStatus * 0x0012f818) line 2035 + 47 bytes
PresShell::HandleEventInternal(nsEvent * 0x0012f9ec, nsIView * 0x0815b660,
unsigned int 1, nsEventStatus * 0x0012f818) line 6236 + 45 bytes
PresShell::HandleEvent(PresShell * const 0x08160ce8, nsIView * 0x0815b660,
nsGUIEvent * 0x0012f9ec, nsEventStatus * 0x0012f818, int 1, int & 1) line 6106 +
25 bytes
nsViewManager::HandleEvent(nsView * 0x0815b660, nsGUIEvent * 0x0012f9ec, int 0)
line 2255
nsView::HandleEvent(nsViewManager * 0x0815b7e0, nsGUIEvent * 0x0012f9ec, int 0)
line 305
nsViewManager::DispatchEvent(nsViewManager * const 0x0815b7e0, nsGUIEvent *
0x0012f9ec, nsEventStatus * 0x0012f95c) line 2038 + 23 bytes
HandleEvent(nsGUIEvent * 0x0012f9ec) line 79
nsWindow::DispatchEvent(nsWindow * const 0x0815b564, nsGUIEvent * 0x0012f9ec,
nsEventStatus & nsEventStatus_eIgnore) line 1049 + 10 bytes
nsWindow::DispatchWindowEvent(nsGUIEvent * 0x0012f9ec) line 1070
nsWindow::DispatchKeyEvent(unsigned int 131, unsigned short 0, unsigned int 8,
long 0) line 2911 + 15 bytes
nsWindow::OnChar(unsigned int 8, unsigned int 8, unsigned char 0) line 3098
nsWindow::ProcessMessage(unsigned int 258, unsigned int 8, long 917505, long *
0x0012fe58) line 3806 + 41 bytes
nsWindow::WindowProc(HWND__ * 0x006c087a, unsigned int 258, unsigned int 8, long
917505) line 1332 + 27 bytes
USER32! SetTimer + 1077 bytes
USER32! DispatchMessageW + 278 bytes
USER32! DispatchMessageA + 11 bytes
main(int 1, char * * 0x00a141f0) line 158 + 11 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! SetUnhandledExceptionFilter + 92 bytes

Comment 1

[timeless]

minimal steps appear to be to have not clicked into the frame after selecting
editmode. any page seems to work.

Comment 2

[Joe Francis]

Attachment: patch to nsHTMLEditRules.cpp

simple null check.

Comment 3

[Kathleen :Brade]

Comment on attachment 130692 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

r=brade but please remove the spaces from the blank line which you added (I
don't want to see this change in your checkin:
       if (NS_FAILED(res) || bInDifTblElems) return res;
-
+      
)

Comment 4

[kinmoz]

Comment on attachment 130692 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

sr=[e-mail]

Comment 5

[Kathleen :Brade]

accepting bug for joe :-)
Joe--if you won't have time, reassign bug to me and I'll land it for you.

Comment 6

[Kathleen :Brade]

-->glazman to land for Joe

Comment 7

[Daniel Glazman (:glazou) (NOT MONITORING BMO ANY MORE)]

checked in