Closed Bug 217918 Opened 21 years ago Closed 19 years ago

tvguide.com - Javascript nexttime() and prevtime() arrows do not work manual selection does work

Categories

(Tech Evangelism Graveyard :: English US, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nikm, Unassigned)

References

()

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

http://www.tvguide.com/listings page uses javascript to display current next and
prev time slots. function is nexttime(). error is selectrow event is not defined
Error: selectrow is not defined
Source File: http://www.tvguide.com/listings/index.asp?sbtry=1
Line: 524
works in IE

Reproducible: Always

Steps to Reproduce:
1. got to site, select listings, enter zip and cable provider, and get listings
2. click on the arrows to advance to the next time slots and does not work.
3. manually selecting time from the drop down menu does advance to the next time
slot.

Actual Results:  
get javascript error

Expected Results:  
advance to previous and next time slots
*** Bug 218017 has been marked as a duplicate of this bug. ***
they use in those functions an unqualified reference to the selectrow form.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Priority: -- → P1
Hardware: PC → All
Summary: Javascript nexttime() and prevtime() arrows do not work manual selection does work → tvguide.com - Javascript nexttime() and prevtime() arrows do not work manual selection does work
the next and prev buttons seem to work but they still have issues

Error: missing ) after argument list
Source File: http://www.tvguide.com/listings/index.asp
Line: 122, Column: 83
Source Code:
    document.write("<area shape='rect' coords='330,1,407,20' href='/news/'
target="_self">

Error: document.all has no properties
Source File: https://subscriptions.tvguide.com/subscribe.aspx
Line: 411

*** Bug 229890 has been marked as a duplicate of this bug. ***
tvguide now requires too much personal information. If someone who has
registered with them wishes to send me the email address they used to register I
will look into this issue further.

comments from Bug 229890

If you go to http://www.tvguide.com/listings/ and put in your zip and everything
you should get a list of channels and upcoming programming on these channels,
but in Mozilla the layout loots different than in IE. The name of the channel
goes into the programming lines and the spacing and everything look different.
Info to login to TV guide

First: Manikin     Last: None
Email: manikinnone@manikin.org
123 Boston Rd
Billerica, MA 01821

NOTE: Most of the info is not quite true ;)
Errors I found:

<link rel="stylesheet" type="text/css" href="/include/css/sectfront.asp">

This is an asp page that reports itself as text/html but it should report itself
as text/css. Not an issue unless they switch to a standards mode doctype.

<link type="text/css" rel="stylesheet" href="/include/css/nostyle.css">

this file contains ASP code intended to set the font-size. Since it is served as
a plain css file, this doesn't work as intended.

The page as the following style element *inside* the body

<style type="text/css">
.headerad {position: absolute; top: 0px; left: 0px; width: 454 px;}
</style>

Apart from a bad location the width has an invalid space between the value and
the unit. e.g. should be width: 454px; not width: 454 px;

They also use MSXML to provide XSLT services on the back end... after all they
are a Windows shop I guess. Note that the page includes XML declarations and raw
XSLT variables which were not replaced in the transform server side:

<?xml version="1.0"?><DIV style="OVERFLOW:auto; WIDTH:100%;" 
^^^^^^^^^^^^^^^^^^^^^
xmlns:msxsl="urn:schemas-microsoft-com:xslt"><table border="0" cellpadding="2" 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cellspacing="1" style="background:#999999;table-layout:fixed;overflow:hidden"
width="100%"><TR><TD height="0" width="13" /><TD height="0" width="3.625" /><TD
height="0" width="3.625" /><TD height="0" width="3.625" /><TD height="0"
width="3.625" /><TD height="0" width="3.625" /><TD height="0" width="3.625"
/><TD height="0" width="3.625" /><TD height="0" width="3.625" /><TD height="0"
width="3.625" /><TD height="0" width="3.625" /><TD height="0" width="3.625"
/><TD height="0" width="3.625" /><TD height="0" width="3.625" /><TD height="0"
width="3.625" /><TD height="0" width="3.625" /><TD height="0" width="3.625"
/><TD height="0" width="3.625" /><TD height="0" width="3.625" /><TD height="0"
width="3.625" /><TD height="0" width="3.625" /><TD height="0" width="3.625"
/><TD height="0" width="3.625" /><TD height="0" width="3.625" /><TD height="0"
width="3.625" /></TR><tr height="18"><td class="gtbr" align="left"
valign="middle" width="$channel_block_width">
                       ^^^^^^^^^^^^^^^^^^^^^
I suggest that any TVGuide users, tell them about the problems in this page. Do
not say just that their page does not support Mozilla, but make it very clear to
them that they *have errors in the programming of their content*.
I've experienced the very same problem, but only on one machine; I'm running
Firefox 1.0 on two boxes, and this problem is only reproducable on my laptop,
not my desktop (but was a problem on the desktop until recently, with a new hard
drive).  

Everything on both my machines is running smoothly, and the Firefox setups are
identical, yet for some reason one machine will red the TV Guide javascript, and
the other won't. This leads me to believe its something other than Firefox or
the TV Guide page, and it's not the only page I've had that problem with, but
it's the easiest page to reproduce the problem.
The TVGuide.com listings have been Working for me (WFM) since about 20-Dec-2005.  I think the TVGuide folks improved their javascript.  Sadly though, the JS Console still shows numerous errors on their site.
I get a couple of same origin errors on location and title, and lots of CSS errors. The next buttons work fine. Marking fixed.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Please reopen this bug.  The nexttime() and prevtime(), etc. features are broken again.
Ron, they work for me with a recent Firefox 1.5 / winxp. What are you using?
Product: Tech Evangelism → Tech Evangelism Graveyard
You need to log in before you can comment on or make changes to this bug.