21829 - Can't stop an imap message/attachment load

Status: NEW

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

Pressing the stop button while loading an imap message does nothing. This is
because we're not passing the msgWindow into the display message service. I'd
like to fix this for m13.

Comment 1

[David :Bienvenu]

accepting

Comment 2

[David :Bienvenu]

marking m14, like the other stop bugs. The solution is to pass an nsMsgWindow
into DisplayMessage, which mscott is doing as part of his speedup for message
loading.

Comment 3

[David :Bienvenu]

Scott fixed this with his reworking of msg loading, by passing in the MsgWindow
to the msg load url.

Comment 4

[David :Bienvenu]

marking fixed, by Mscott

Comment 5

[Scott MacGregor]

I like it when bugs get fixed this way =).

Comment 6

[Karen Huang]

Verified on Linux 01-11-10, WinNT 01-13-15 & Mac 01-12-08-M13 commercial build.
Stop button works for loading IMAP messages now. Marking as verified!!

Comment 7

[Karen Huang]

Reopen this bug since problem still occurring on 02-16-08-M14 commercial build.

Comment 8

[David :Bienvenu]

worked fine for me yesterday. Don't know why anything would have changed.

Comment 9

[lchiang]

Karen - this happens for you?  

Comment 10

[Karen Huang]

Yes. Problem still occurring on 02-18-09-M14 commercial build.
Let me attached the 949KB attachment message here...
The thing is: when I pressed the stop button, the message should stop 
downloading the message right away, also the message shouldn't display 
completely...on 5.0, even the messages meter stop in th emiddle, but the message 
still displayed message almost completely...

Comment 11

[Karen Huang]

Attachment: 949KB attached file

Comment 12

[David :Bienvenu]

attaching a protocol log would be useful. Again, this works fine for me. Perhaps 
you should try it over a slow connection so you can catch it in the act.

Comment 13

[Karen Huang]

But why I used the same attachment on 4.x for "same machine" and I can see that 
after I press the stop button, the 4.x stop right away and the attachment didn't 
display completely?

Comment 14

[Karen Huang]

Anyway, I will try on slow machine again....

Comment 15

[Karen Huang]

OK. I found out that the "stop" only work for the first time loading message:

Here are the setup & some test scenarios/problems:

Setup: 
Win98/133Mhz
Attachmen: 591KB image file (Since slow machine, so I used this file instead)

Test Scenarios:
1) If I stop the message at the first time, it will stop.
2) If I load the message completely at the first time, and tried to stop the 
message start from the second time, it won't stop message anymore.
3) If I stop the message at the first time, it will stop....but after the second 
time and tried to display messages completely, it won't display completely 
anymore....

Summary: 
1) The stop button is working but not works completely.
2) The "resume" (no matter stop or loading again) seemed not work well, may need 
to log another bug?


   

Comment 16

[Karen Huang]

Attachment: 591KB image .jpg file

Comment 17

[Scott MacGregor]

Moving my remaining M14 bugs to M15 which is the next targeted milestone.

Comment 18

[Scott MacGregor]

Since the problem is ocurring the 2nd time you try to load a message it must be
a problem with stopping loads coming from the memory cache...

Comment 19

[David :Bienvenu]

yes, I should have added a comment to that effect - that's why I reassigned it
to you. It's also why this is not a very important bug. But it does beg the
question : we shouldn't be putting huge messages in the memory cache.

Comment 20

[selmer (gone)]

Mass moving M16 to M17 - look for nsbeta2 before anything else.

Comment 21

[scottputterman]

moving to future milestone.

Comment 22

[Michal 'hramrach' Suchanek]

Mozilla 0.9.6 WinNT4 sp6

I cant stop connecting to server when I try to open an IMAP folder. The stop
button doesnt work and after some time the connection times out. The server is
probably down in this case.

Comment 23

[Andrew Hagen]

--> IMAP.

Comment 24

[Bogdan Stroe]

See also bug 248927.

Comment 25

[Florian Effenberger]

Stop button does not work at all in Thunderbird 0.6-0.8. :-(

Please fix this, as this is a very elementary UI element and function that 
simply does NOTHING.

Cf. Bug 239616

Comment 26

[David :Bienvenu]

I wonder if this is still broken...

Comment 27

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #26)
> I wonder if this is still broken...

Nikolay/rsx11m, could you test this?  n.b. comment 25 and friends.

Comment 28

[rsx11m]

Testing with 10.0.2 on Windows 7 and offline synchronization switched off, loading a message with a large attachment *can* be interrupted by the Stop button dragged onto the main toolbar from the customization palette. So, that part works.

Observations: The ESC key doesn't work as keyboard shortcut. Also, the attachment is shown as being intact and of the correct type, the size indicated reflects the actually downloaded size and thus is wrong. Trying to open the attachment will initiate reloading of the message from the server.

With offline synchronization being the default these days, it's not clear to me whether or not the Stop button has any influence on the synchronization actions.

Comment 29

[rsx11m]

(In reply to rsx11m from comment #28)
> Observations: The ESC key doesn't work as keyboard shortcut.

Per bug 579576, ESC is only associated with quick-filter actions, not cmd_stop.

Comment 30

[[e-mail]]

(In reply to rsx11m from comment #28)
> Testing with 10.0.2 on Windows 7 and offline synchronization switched off,
> loading a message with a large attachment *can* be interrupted by the Stop
> button dragged onto the main toolbar from the customization palette. So,
> that part works.

Out of interest, some of the comments seem to that suggest that the problem still exists when switching between messages that have already been (partially?) read previously in the current session, did you try that at all?

Comment 31

[rsx11m]

(In reply to Scott MacGregor from comment #18)
> Since the problem is ocurring the 2nd time you try to load a message it must be
> a problem with stopping loads coming from the memory cache...

I've switched between two messages with larger attachments and allowed them to load completely (in which case the 2nd read took the cached version without the need to connect to the server, thus the issue doesn't apply) or interrupted during the load process, and in both variants the Stop button behaved as expected.

Comment 32

[Wayne Mery (:wsmwk)]

(In reply to rsx11m from comment #31)
> (In reply to Scott MacGregor from comment #18)
> > Since the problem is ocurring the 2nd time you try to load a message it must be
> > a problem with stopping loads coming from the memory cache...
> 
> I've switched between two messages with larger attachments and allowed them
> to load completely (in which case the 2nd read took the cached version
> without the need to connect to the server, thus the issue doesn't apply) or
> interrupted during the load process, and in both variants the Stop button
> behaved as expected.

I did only a little testing, and had mixed results with bug 58692 - which seems about the same thing.


> With offline synchronization being the default these days, it's not clear to me whether or not the Stop button has any influence on the synchronization actions.

Indeed, it doesn't seem like stop should be expected to do anything in that case.