218411 - Duplicate contact is added even though address being sent to is in the Additional Email field (collection)

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Paul Coyle]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

After sending an email to the "Additional Email" of a contact in your address
book with both "Email" and "Additional Email" fields filled in will add this
contact to the address book again with the same name and the "Additional Email"
as the "Email" field.

Reproducible: Always

Steps to Reproduce:
1. Create a contact filling in both the "Email" and "Additional Email" fields
2. Send mail to the "Additional Email" from step 1

Actual Results:  
Duplicate contact added to address book with "Email" field populated as
"Aditional Email" from previous contact.

Expected Results:  
Nothing.

Comment 1

[Scott MacGregor]

putting in right component

Comment 2

[Jim]

I believe my problem is related to this one.
To create duplicate entries...
1) Add e-mail address to Address Book.  (ex.  Name "Johny", Email "[e-mail]") 
2) e-mail "Johny" and have "Johny" reply.
3) Suspose "Johny" replys and his profile is setup as
   "Smith, John"  [e-mail]
4) Reply to "Johny"'s reply.
5) A new Address book entry is added with Name "Smith, John", Email "[e-mail]")

I don't want a new entry for "[e-mail]".  I want to keep the one I have and
leave the name as "Johny".

Comment 3

[earthsound]

does this bug depend on a fix for ancient bug 45946?

Comment 4

[Achim Schilder]

Another example of bad behaviour:

"Johny" third email "[e-mail]" produces a third entry.

The email address should be treated case insensitive.

Comment 5

[Mark Banner (:standard8)]

*** Bug 278323 has been marked as a duplicate of this bug. ***

Comment 6

[Mark Banner (:standard8)]

*** Bug 317688 has been marked as a duplicate of this bug. ***

Comment 7

[Mark Banner (:standard8)]

Added (collection) onto summary to make it easier to search for & taking.

Comment 8

[Mark Banner (:standard8)]

Attachment: Check in additional email address as well.

This patch adds an additional check so if the email is not found in the primary email address for the database, we also then check the additional email address.

Additionally, if the email is found in the additional email address field, we then don't update the card.

I was a bit concerned about performance, but searching a 1000 contact database twice in the way that this patch seems to take no time at all (i.e. < 1 second), its the actual sending that takes the time...

Comment 9

[David :Bienvenu]

Comment on attachment 204939 [details] [diff] [review]
Check in additional email address as well.

looks OK -it's too bad we can't use FindRow for this, but it will only find one instance...

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 204939 [details] [diff] [review]
Check in additional email address as well.

sr=dmose

Comment 11

[Mark Banner (:standard8)]

Fix checked into trunk:

/cvsroot/mozilla/mailnews/addrbook/src/nsAbAddressCollecter.cpp,v  <--  nsAbAddressCollecter.cpp
new revision: 1.56; previous revision: 1.55

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 204939 [details] [diff] [review]
Check in additional email address as well.

Requesting approval for 1.8.1 branch.

This patch has been on trunk for a while now. It improves our collected addresses handling to reduce the amount of duplicates that we create.

Comment 13

[Mark Banner (:standard8)]

Patch checked into 1.8 branch.
Checking in mailnews/addrbook/src/nsAbAddressCollecter.cpp;
/cvsroot/mozilla/mailnews/addrbook/src/nsAbAddressCollecter.cpp,v  <--  nsAbAddressCollecter.cpp
new revision: 1.55.2.1; previous revision: 1.55

Comment 14

[Marcia Knous [:marcia]]

verified on the 1.8 branch using the tbird cand build, version 2.0.0.0 (20070326). I verified on Win Vista, following the STR in the reporter's comment. I did not get a duplicate address book entry. Adding branch verified keyword.