Last Comment Bug 218618 - [PatchReader] Show line numbers on patch attachments
: [PatchReader] Show line numbers on patch attachments
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Attachments & Requests (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: Bugzilla 3.2
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2003-09-08 02:02 PDT by Brian 'netdragon' Bober
Modified: 2008-07-01 00:07 PDT (History)
2 users (show)
LpSolit: approval+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (7.92 KB, patch)
2007-05-26 14:56 PDT, Frédéric Buclin
justdave: review+
Details | Diff | Splinter Review
Screenshot (134.52 KB, image/png)
2008-06-30 22:23 PDT, Max Kanat-Alexander
no flags Details

Description Brian 'netdragon' Bober 2003-09-08 02:02:20 PDT
It would be nice if Bugzilla let you be able to view patch attachments with line
numbers added to the beginning of the lines, yet still download them without
them. That would be good for when you are reviewing a long patch, because you
could refer to a line to help guide the person to finding what was wrong with
their patch.
Comment 1 Dave Miller [:justdave] (justdave@bugzilla.org) 2003-09-08 07:18:05 PDT
jkeiser: Does the new patch viewer do this already?
Comment 2 Max Kanat-Alexander 2007-03-06 17:02:18 PST
PatchReader shows the patched lines, but doesn't show the line numbers next to each line.
Comment 3 Frédéric Buclin 2007-05-26 14:56:44 PDT
Created attachment 266220 [details] [diff] [review]
patch, v1

Screenshot available at http://landfill.bugzilla.org/qa30pg/attachment.cgi?id=402
Comment 4 Dave Miller [:justdave] (justdave@bugzilla.org) 2007-05-26 15:14:23 PDT
Comment on attachment 266220 [details] [diff] [review]
patch, v1

I like this.  A little voice in my head is saying we might want a link to show/hide them but that can be another bug if people complain.  You've already got a class on them, so it should be painless to hide/show that class on a clicky if someone feels that badly ;)
Comment 5 Frédéric Buclin 2007-05-26 15:35:05 PDT
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.104; previous revision: 1.103
done
Checking in template/en/default/attachment/diff-file.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-file.html.tmpl,v  <--  diff-file.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v  <--  diff-header.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Comment 6 Max Kanat-Alexander 2008-06-30 22:23:28 PDT
Created attachment 327546 [details]
Screenshot

Adding the example screenshot to the bug here, so that we can link to it from the Release Notes (don't want to link to landfill).
Comment 7 Max Kanat-Alexander 2008-07-01 00:07:19 PDT
Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.

Note You need to log in before you can comment on or make changes to this bug.