The default bug view has changed. See this FAQ.

[PatchReader] Show line numbers on patch attachments

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
Attachments & Requests
--
enhancement
RESOLVED FIXED
14 years ago
9 years ago

People

(Reporter: Brian 'netdragon' Bober, Assigned: Frédéric Buclin)

Tracking

unspecified
Bugzilla 3.2
Bug Flags:
approval +

Details

Attachments

(2 attachments)

(Reporter)

Description

14 years ago
It would be nice if Bugzilla let you be able to view patch attachments with line
numbers added to the beginning of the lines, yet still download them without
them. That would be good for when you are reviewing a long patch, because you
could refer to a line to help guide the person to finding what was wrong with
their patch.
jkeiser: Does the new patch viewer do this already?

Updated

11 years ago
QA Contact: mattyt-bugzilla → default-qa
(Assignee)

Updated

10 years ago
Assignee: myk → attach-and-request

Comment 2

10 years ago
PatchReader shows the patched lines, but doesn't show the line numbers next to each line.
Summary: Show line numbers on patch attachments → [PatchReader] Show line numbers on patch attachments
(Assignee)

Comment 3

10 years ago
Created attachment 266220 [details] [diff] [review]
patch, v1

Screenshot available at http://landfill.bugzilla.org/qa30pg/attachment.cgi?id=402
Assignee: attach-and-request → LpSolit
Status: NEW → ASSIGNED
Attachment #266220 - Flags: review?
(Assignee)

Updated

10 years ago
Target Milestone: --- → Bugzilla 3.2
Comment on attachment 266220 [details] [diff] [review]
patch, v1

I like this.  A little voice in my head is saying we might want a link to show/hide them but that can be another bug if people complain.  You've already got a class on them, so it should be painless to hide/show that class on a clicky if someone feels that badly ;)
Attachment #266220 - Flags: review? → review+
(Assignee)

Updated

10 years ago
Flags: approval+
Keywords: relnote
(Assignee)

Comment 5

10 years ago
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.104; previous revision: 1.103
done
Checking in template/en/default/attachment/diff-file.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-file.html.tmpl,v  <--  diff-file.html.tmpl
new revision: 1.6; previous revision: 1.5
done
Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v  <--  diff-header.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 6

9 years ago
Created attachment 327546 [details]
Screenshot

Adding the example screenshot to the bug here, so that we can link to it from the Release Notes (don't want to link to landfill).

Comment 7

9 years ago
Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.