It would be nice if Bugzilla let you be able to view patch attachments with line numbers added to the beginning of the lines, yet still download them without them. That would be good for when you are reviewing a long patch, because you could refer to a line to help guide the person to finding what was wrong with their patch.
jkeiser: Does the new patch viewer do this already?
PatchReader shows the patched lines, but doesn't show the line numbers next to each line.
Created attachment 266220 [details] [diff] [review] patch, v1 Screenshot available at http://landfill.bugzilla.org/qa30pg/attachment.cgi?id=402
Comment on attachment 266220 [details] [diff] [review] patch, v1 I like this. A little voice in my head is saying we might want a link to show/hide them but that can be another bug if people complain. You've already got a class on them, so it should be painless to hide/show that class on a clicky if someone feels that badly ;)
Checking in template/en/default/filterexceptions.pl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v <-- filterexceptions.pl new revision: 1.104; previous revision: 1.103 done Checking in template/en/default/attachment/diff-file.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-file.html.tmpl,v <-- diff-file.html.tmpl new revision: 1.6; previous revision: 1.5 done Checking in template/en/default/attachment/diff-header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v <-- diff-header.html.tmpl new revision: 1.16; previous revision: 1.15 done
Created attachment 327546 [details] Screenshot Adding the example screenshot to the bug here, so that we can link to it from the Release Notes (don't want to link to landfill).
Added to the release notes for Bugzilla 3.2 in a patch on bug 432331.