[W] UMR: Uninitialized memory read in nsView::ConvertToParentCoords(int *,int *)const

RESOLVED FIXED

Status

()

RESOLVED FIXED
16 years ago
5 months ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

16 years ago
mkaply ran purify on windows on a simple task:
run mozilla, load homepage (mozilla.org?), print, quit.

I'll attach a log and a patch.
(Assignee)

Comment 1

16 years ago
Created attachment 131179 [details]
purify log excerpt
(Assignee)

Comment 2

16 years ago
Created attachment 131180 [details] [diff] [review]
Fix UMR and stop treating the pointers like integers
(Assignee)

Updated

16 years ago
Attachment #131180 - Flags: superreview?(roc)
Attachment #131180 - Flags: review?(roc)
This is fine, but you need to fix this call site:
http://lxr.mozilla.org/seamonkey/source/view/src/nsScrollPortView.cpp#385
this code wants to add the view offset to the aDx, aDy passed in.
(Assignee)

Updated

16 years ago
Attachment #131180 - Flags: superreview?(roc)
Attachment #131180 - Flags: review?(roc)
(Assignee)

Comment 4

16 years ago
Created attachment 131204 [details] [diff] [review]
Fix UMR and stop treating the pointers like integers, don't lose input
(Assignee)

Updated

16 years ago
Attachment #131180 - Attachment is obsolete: true
(Assignee)

Updated

16 years ago
Attachment #131204 - Flags: superreview?(roc)
Attachment #131204 - Flags: review?(roc)
Attachment #131204 - Flags: superreview?(roc)
Attachment #131204 - Flags: superreview+
Attachment #131204 - Flags: review?(roc)
Attachment #131204 - Flags: review+
(Assignee)

Comment 5

16 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Component: Layout: View Rendering → Layout: Web Painting
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.