Closed
Bug 219104
Opened 21 years ago
Closed 21 years ago
Mac builds not loading URLs because PRNetAddr::raw.family is 4098 instead of 2
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: darin.moz)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.03 KB,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
The mac builds on our two trunk tinderboxes (including the current nightly) don't load URLs. This is because on Linux, struct sockaddr looks like this: unsigned short int sa_family; unsigned char sa_data[14]; but on Mac it looks like this: u_char sa_len; /* total length */ u_char sa_family; /* address family */ char sa_data[14]; /* actually longer; address value */ So you can't memcpy a sockaddr struct into a PRNetAddr as PR_EnumerateAddrInfo does. bryner deserves most of the credit for figuring this out. In any case, I'll attach the patch I put on the tinderboxes so that they run again. It may not be the right thing, but it seems to work.
Reporter | ||
Comment 1•21 years ago
|
||
Patch I put on the two Mac tinderboxes that makes the world work again.
Assignee | ||
Comment 2•21 years ago
|
||
crap! thanks for working up a fix for this. sounds like we should replace this code block with field-by-field assignment in case there happen to be other instances where this memcpy causes problems.
Comment 3•21 years ago
|
||
Comment on attachment 131387 [details] [diff] [review] patch r=wtc. This patch ensures that the sa_len field, which exists in the sockaddr structure on some platforms (usually derivatives of BSD4.4), is not copied to PRNetAddr. I've checked in this patch on the NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.6 alpha) and NSPR trunk (NSPR 4.5).
Attachment #131387 -
Flags: review+
Comment 4•21 years ago
|
||
from bug 219088 comment 4 This patch seems to me working on FreeBSD, and a reporter says that it works on Mac OS X too. Please check in on 1.5 final. Otherwise Mac and FreeBSD (and *BSD?) users will go away. This is a Blocker and regression for us. -> Blocker/regression/1.5?
Comment 5•21 years ago
|
||
Mozilla 1.5 does not have the new code that has this bug. The new code was only checked into Mozilla 1.6 (alpha) development trunk.
Flags: blocking1.5?
Comment 6•21 years ago
|
||
*** Bug 219126 has been marked as a duplicate of this bug. ***
*** Bug 219166 has been marked as a duplicate of this bug. ***
On MacOSX, 2003091705-trnuk build still have this problem. When I tested new profile, I can't access to start page(http://www.mozilla.org/start/). BTW, does this bug relate to bug 219150? See Mozillazine forum(Firebird Bugs). http://forums.mozillazine.org/viewtopic.php?t=24948
Comment 9•21 years ago
|
||
This bug has been fixed. hub-san@mozilla.gr.jp, could you file a new bug about your problem?
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 10•21 years ago
|
||
Sorry for the spam; I have added my comment to bug 219512. http://bugzilla.mozilla.org/show_bug.cgi?id=219512#c4 Web pages loads hang for several minutes before finishing.
You need to log in
before you can comment on or make changes to this bug.
Description
•