219239 - Junk Mail Controls dialog size and placement are not remembered

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Stefan Borggraefe]

Regression caused by the check-in from bug 180215.

Comment 1

[[e-mail]]

IMHO it should not be resizable, it has no resizable content.

Let's see what the module owners have to say about it.

Comment 2

[Stefan Borggraefe]

Attachment: Changes the Junk Mail Controls dialog so it's not resizable and remembers its position

Neil: I see your point. So this patch changes the dialog so it's not resizable
(as intended but not achieved by bug 180215, right?) and only remembers its
position.

Comment 3

[[e-mail]]

Comment on attachment 131493 [details] [diff] [review]
Changes the Junk Mail Controls dialog so it's not resizable and remembers its position

Sorry, JavaScript doesn't support overloading, but you could look into optional
arguments instead.

Comment 4

[Stefan Borggraefe]

Comment on attachment 131493 [details] [diff] [review]
Changes the Junk Mail Controls dialog so it's not resizable and remembers its position

/me writes 100 times "JavaScript is not Java". ;-)

The funny thing is that this patch worked like expected for the Junk Mail
Controls dialog. But after your r- I checked the other dialogs opened by
OpenOrFocusWindow and noticed, they were affected by my patch, too.

Comment 5

[Stefan Borggraefe]

Attachment: Corrected fix.

Using an optional argument this time.

Comment 6

[Stefan Borggraefe]

<Neil> Stefan: I got email back from bienvenu - he said please make Junk Mail
Controls a modal dialog.

<Stefan> Neil: ok, I'll update my patch for that bug.

Comment 7

[Stefan Borggraefe]

Attachment: Junk Mail Controls dialog is now modal

Comment 8

[[e-mail]]

Comment on attachment 131742 [details] [diff] [review]
Junk Mail Controls dialog is now modal

Sorry, we only use OpenOrFocusWindow for modeless windows, for modal windows
just call openDialog directly.

Comment 9

[Stefan Borggraefe]

Attachment: revised Patch

Now MsgJunkMail() just calls window.openDialog().

Comment 10

[[e-mail]]

Comment on attachment 131750 [details] [diff] [review]
revised Patch

>+  window.openDialog("chrome://messenger/content/junkMail.xul", "",
>+                    "chrome,resizable=no,modal,dialog=no", args);
dialog=no does something odd (breaks dependency?).

>@@ -2209,5 +2210,3 @@
>   else
>     window.openDialog(chromeURL, "", "chrome,resizable,status,centerscreen,dialog=no", args);
> }
>-
>-

Let's not have this change in the next patch :-)

Comment 11

[Stefan Borggraefe]

Attachment: Final patch (I hope so)

Comment 12

[[e-mail]]

Comment on attachment 131762 [details] [diff] [review]
Final patch (I hope so)

Ok, that works fine now.

Comment 13

[David :Bienvenu]

Comment on attachment 131762 [details] [diff] [review]
Final patch (I hope so)

sr=bienvenu

Comment 14

[Stefan Borggraefe]

The fix was checked in by Neil.