219362 - make chrome target recursive

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Benjamin Smedberg]

Sometimes I need to rebuild just chrome, recursively through the entire tree. A
simple "chrome-recurse" target makes this pretty simple.

Comment 1

[Benjamin Smedberg]

Attachment: add chrome-recurse Makefile target

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 131554 [details] [diff] [review]
add chrome-recurse Makefile target

i'm thinking we should just change 'make chrome' to do this, rather than adding
a new target

Comment 3

[Benjamin Smedberg]

Comment on attachment 131554 [details] [diff] [review]
add chrome-recurse Makefile target

bryner: several people on #mozilla expressed reservations about making the
chrome target recursive by default... I don't know why, precisely.

Also, this needs to be LOOP_OVER_MOZ_DIRS, which I have fixed in my local tree.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

hm... I would prefer if "make chrome" wasn't recursive, to make it faster.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 131554 [details] [diff] [review]
add chrome-recurse Makefile target

All of our other targets are recursive, I don't see why 'chrome' should be any
different.

Comment 6

[Benjamin Smedberg]

Attachment: make chrome target recursive

OK, then. This makes the "chrome" target recursive by default. If you don't
want the recursive behavior you can use the "realchrome" target.

Comment 7

[cls]

Comment on attachment 133000 [details] [diff] [review]
make chrome target recursive

The chrome target needs to explicitly call |$(MAKE) realchrome| otherwise you
could run into a race condition in parallel builds. 
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/rules.mk&rev=3.357#3.2
76

Comment 8

[Benjamin Smedberg]

fixed-on-trunk with corrections by cls