219381 - pref_Alert should print to stderr on windows and if pref_Alert is called we shouldn't assert

Status: RESOLVED INVALID

(Core :: Preferences: Backend, enhancement)

Description

[timeless]

winpref.js, SyntaxError: illegal character. /* -*- Mode: Java; tab-width: 4;
indent-tabs-mode: nil; c-basic-offset: 2 -*- */
###!!! ASSERTION: <platform>.js was not parsed successfully: 'NS_SUCCEEDED(rv)',
file i:/build/mozilla/modules/libpref/src/nsPrefService.cpp, line 800
Break: at file i:/build/mozilla/modules/libpref/src/nsPrefService.cpp, line 800

People can break into the debugger while the alert is open so the assertion is
duplicative.

Comment 1

[timeless]

Attachment: make it so

Comment 2

[Darin Fisher]

Comment on attachment 131559 [details] [diff] [review]
make it so

indentation looks a little wierd in that method.  maybe MessageBox is over
indented?  do we want to call PR_GetEnv instead of getenv?  do you want to
issue a NS_WARNING in place of the NS_ASSERTION instead of no output at all?

Comment 3

[timeless]

Comment on attachment 131559 [details] [diff] [review]
make it so

i'll gladly fix the indentation of the messagebox.

i am getting output, openPrefFile calls pref_Alert which spews to the console
(and possibly messageboxes), there's no need for another dialog or additional
output.

Comment 4

[Alec Flett]

Comment on attachment 131559 [details] [diff] [review]
make it so

seems fine, though I can't remember, does XP_MAC refer to MacOSX too? Because I
think we'd want the console spew on OSX.

r=alecf with console spew on OSX

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

XP_MAC is classic mac only, XP_MACOSX is for osx

Comment 6

[Phil Ringnalda (:philor)]

Missed the boat on this one: both chunks were gone by 1.7.