pref_Alert should print to stderr on windows and if pref_Alert is called we shouldn't assert

RESOLVED INVALID

Status

()

Core
Preferences: Backend
--
enhancement
RESOLVED INVALID
15 years ago
10 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.37 KB, patch
Alec Flett
: review+
Darin Fisher
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
winpref.js, SyntaxError: illegal character. /* -*- Mode: Java; tab-width: 4;
indent-tabs-mode: nil; c-basic-offset: 2 -*- */
###!!! ASSERTION: <platform>.js was not parsed successfully: 'NS_SUCCEEDED(rv)',
file i:/build/mozilla/modules/libpref/src/nsPrefService.cpp, line 800
Break: at file i:/build/mozilla/modules/libpref/src/nsPrefService.cpp, line 800

People can break into the debugger while the alert is open so the assertion is
duplicative.
(Assignee)

Comment 1

15 years ago
Created attachment 131559 [details] [diff] [review]
make it so
(Assignee)

Updated

15 years ago
Attachment #131559 - Flags: superreview?(dveditz+bmo)
Attachment #131559 - Flags: review?(dveditz+bmo)
(Assignee)

Updated

15 years ago
Attachment #131559 - Flags: superreview?(dveditz+bmo) → superreview?(darin)

Comment 2

15 years ago
Comment on attachment 131559 [details] [diff] [review]
make it so

indentation looks a little wierd in that method.  maybe MessageBox is over
indented?  do we want to call PR_GetEnv instead of getenv?  do you want to
issue a NS_WARNING in place of the NS_ASSERTION instead of no output at all?
Attachment #131559 - Flags: superreview?(darin) → superreview+
(Assignee)

Comment 3

15 years ago
Comment on attachment 131559 [details] [diff] [review]
make it so

i'll gladly fix the indentation of the messagebox.

i am getting output, openPrefFile calls pref_Alert which spews to the console
(and possibly messageboxes), there's no need for another dialog or additional
output.
Attachment #131559 - Flags: review?(dveditz+bmo) → review?(alecf)

Comment 4

15 years ago
Comment on attachment 131559 [details] [diff] [review]
make it so

seems fine, though I can't remember, does XP_MAC refer to MacOSX too? Because I
think we'd want the console spew on OSX.

r=alecf with console spew on OSX
Attachment #131559 - Flags: review?(alecf) → review+
XP_MAC is classic mac only, XP_MACOSX is for osx
Missed the boat on this one: both chunks were gone by 1.7.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.