219521 - nsDragService leaks gdk window because it shuts down after event loop

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Gtk, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsDragService leaks one gdk window because it shuts down after the main event
loop does.  I'll attach a patch that fixes this leak.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

meant to assign to self

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[Christopher Blizzard (:blizzard)]

Did you want this reviewed?  (If so, what about gtk2? :)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 131636 [details] [diff] [review]
patch

Sure, although I'm not crazy about adding this much code to fix what's just a
shutdown leak, except that it does make it easier to find real leaks (like bug
219536).

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, GTK2.  I guess I should see if GTK2 has the same problem.  I don't have a
GTK2 debug tree right now, though.  I probably ought to, for both leaks and
broken opacity.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch for gtk2

The same is true for GTK2.  Here's the GTK2 patch.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-10-29 17:48 -0800.