Closed Bug 219619 Opened 21 years ago Closed 19 years ago

addresses in mailing list editor should be LTR even when the UI is RTL

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Product:
SeaMonkey
Component:
MailNews: Address Book & Contacts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: tsahi_75, Assigned: standard8)

References

(Blocks 1 open bug)

Details

(Keywords: rtl)

Attachments

(1 file)

Patch v1 (Checked in)
3.03 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
asa
: approval-aviary1.1a2+
asa
: approval1.8b3+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; he-IL; rv:1.4) Gecko/20030624

when using a language pack of a RTL language, like hebrew or arabic, the UI is
aligned left. when opening the mailing lists editor, the addresses in it are
also aligned right, although email addresses are in latin charactes. see bug
157607 comment 5 for discussion on the addresses in the message compose window,
where there is a similar type of data.

Reproducible: Always

Steps to Reproduce:
1.aligning the interface to the right: add these lines to the file intl.css, in
the locale\en-US\global, in the en-US.jar file (the language pack file, in the
chrome folder):

/*make UI RTL */

window,dialog,wizard,page { direction: rtl; }

menu { direction: rtl; }

outliner { direction: rtl; }

/*
 * make sure search from address bar remains in RTL
 */

#urlbar .autocomplete-search-engine
{
direction: rtl !important;
}

/*
 * keep Composer <HTML> Source tab LTR
 */

#content-source,
#doctype-text { direction: ltr; }

2. make sure you have a mailing list in the address bar
3. double click a mailing list, or select it and click the "properties" botton.

Actual Results:  
all addresses are aligned right

Expected Results:  
addresses should be aligned left

like in bug 157607, the css class uri-element should be added to the proper xul
file to fix this.
Blocks: 219070
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Browser → Seamonkey
Assignee: sspitzer → mail
Assignee: mail → bugzilla
OS: Windows XP → All
Hardware: PC → All
This patch aligns the addresses on the mailing list dialog left even when rtl
is selected (applies to both suite & tb). Tested using the steps in comment 0.
I checked the new/edit card dialogs and they seem to have been done at some
earlier stage.

Tsahi: thanks for the useful testing info.
Attachment #183850 - Flags: superreview?(bienvenu)
Attachment #183850 - Flags: review?(bienvenu)
David, any chance of you taking a look at the review for the attached patch
sometime?
Attachment #183850 - Flags: superreview?(bienvenu)
Attachment #183850 - Flags: superreview+
Attachment #183850 - Flags: review?(bienvenu)
Attachment #183850 - Flags: review+
Comment on attachment 183850 [details] [diff] [review]
Patch v1 (Checked in)

Low risk patch to fix some LTR/RTL issues on seamonkey & thunderbird address
books.
Attachment #183850 - Flags: approval1.8b3?
Attachment #183850 - Flags: approval-aviary1.1a2?
Attachment #183850 - Flags: approval1.8b3?
Attachment #183850 - Flags: approval1.8b3+
Attachment #183850 - Flags: approval-aviary1.1a2?
Attachment #183850 - Flags: approval-aviary1.1a2+
Comment on attachment 183850 [details] [diff] [review]
Patch v1 (Checked in)

Checking in mailnews/addrbook/resources/content/abListOverlay.xul;
new revision: 1.21; previous revision: 1.20
mail/components/addrbook/content/abEditListDialog.xul;
new revision: 1.5; previous revision: 1.4
mail/components/addrbook/content/abMailListDialog.xul;
new revision: 1.5; previous revision: 1.4
done
Attachment #183850 - Attachment description: Patch v1 → Patch v1 (Checked in)
Thanks to IanN for checking this in, this bug is now fixed.
Err, looks like I forgot to mark this as resolved. Second attempt coming up...
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: