219681 - log save/launch errors to nspr log

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsExternalAppHandler::SendStatusChange currently uses a printf in an #ifdef
DEBUG_LAW to log its errors. It would be better if this would use NSPR Logging,
so that not only DEBUG_law builds can see the details of this error

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 131733 [details] [diff] [review]
patch

r=bzbarsky

Comment 3

[Darin Fisher]

Comment on attachment 131733 [details] [diff] [review]
patch

>Index: nsExternalHelperAppService.cpp

>+    PR_LOG(nsExternalHelperAppService::mLog, PR_LOG_ERROR,
>+        ("Error: %s, listener=0x%p, rv=0x%08X\n", NS_LossyConvertUCS2toASCII(msgId).get(), mWebProgressListener.get(), rv));

note: under glibc, %p already has the 0x prepended (at least that's what
the man page says).

sr=darin

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in as is (per irc discussion), because PR_LOG uses nspr printf, which
does not prepend 0x.

Checking in nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <-- 
nsExternalHelperAppService.cpp
new revision: 1.218; previous revision: 1.217
done
Checking in nsExternalHelperAppService.h;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.h,v  <-- 
nsExternalHelperAppService.h
new revision: 1.48; previous revision: 1.47
done