219694 - Update Installer to 1.5 in mozilla/config/milestone.txt for MOZILLA_1_5_BRANCH

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jacek Piskozub]

The value in milestone.txt is still 1.5b. This has already made us ship
mozilla1.5rc1 with wrong Release Notes link (bug 219566).

Marking as blocker per gerv comment in bug 219566.

Comment 1

[Michael Lefevre]

taking a guess as to who this should be reassigned to, and cc'ing people that
may be relevant...

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Change value to "1.5".

Gerv

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 131800 [details] [diff] [review]
Patch v.1

Requesting a rubberstamp r= from leaf.

Gerv

Comment 4

[Malcolm Rowe]

*** Bug 219566 has been marked as a duplicate of this bug. ***

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 131800 [details] [diff] [review]
Patch v.1

Requesting r/sr from dbaron, given that he drove bug 219695 to completion.

Gerv

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 131800 [details] [diff] [review]
Patch v.1

Sure, but there might be some other version numbers that need updating too. 
I'm not sure how many of the ones listed in
http://mozilla.org/build/release-checklist.html still do.

Comment 7

[Gervase Markham [:gerv]]

Attachment: Patch v.2

dbaron: thanks for that pointer.

This updates all the files in that document which need updating except for
localeVersion and skinVersion, which I will leave (if necessary at all) to
people who know more about it than me.

Gerv

Comment 8

[Gervase Markham [:gerv]]

Comment on attachment 131918 [details] [diff] [review]
Patch v.2

You need to know that I haven't compiled with these changes (not having access
to a Mac.) Changing strings really _shouldn't_ break anything, but...

Gerv

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 131918 [details] [diff] [review]
Patch v.2


>Index: xpinstall/wizard/mac/rsrc/MacInstallerVersion.r
>@@ -35,10 +35,10 @@
> resource 'vers' (2, "Mozilla Installer version") {
>         1,
>         0x40,

This line should be 0x50, judging by previous versions.

>-        alpha,	// {alpha, beta, release}
>+        release,	// {alpha, beta, release}
>         0,			// alpha or beta number; 0 for release
>         0,			// language
>-        "1.4a",		// short version string
>-        "Mozilla 1.4a Installer"	// long version string
>+        "1.5",		// short version string
>+        "Mozilla 1.5 Installer"	// long version string
> };
> 


>Index: xpfe/global/resources/locale/en-US/brand.dtd

Hold off on this until the localeVersion changes, I think.




With those changes, sr=dbaron.

Comment 10

[Joe Infla]

*** Bug 220023 has been marked as a duplicate of this bug. ***

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 131918 [details] [diff] [review]
Patch v.2

a=asa (on behalf of drivers) for checkin to the 1.5 branch. Please add the
fixed1.5 keyword when this fix lands on the branch.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_5_BRANCH, 2003-09-23 15:36 -0700.

Comment 13

[Jacek Piskozub]

Verifying per obviousness.