Remove search-db.rdf and use the index and contents to search instead.

VERIFIED FIXED

Status

SeaMonkey
Help Documentation
VERIFIED FIXED
15 years ago
14 years ago

People

(Reporter: R.J. Keller, Assigned: R.J. Keller)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.67 KB, patch
neil@parkwaycc.co.uk
: review+
Alec Flett
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

15 years ago
search-db.rdf, according to oeschger, was used only to modify the search results
of the Help menu search. Mainly used for marketing. This file is not needed,
since any entries in this file should also be in the help index.

So, we should remove search-db.rdf, and add searching of the help index. Any
entries that should be searched for should be added to the index.
(Assignee)

Updated

15 years ago
Depends on: 219120
(Assignee)

Updated

15 years ago
Blocks: 190169
(Assignee)

Comment 1

15 years ago
Created attachment 132267 [details] [diff] [review]
Patch

Note that this patch includes removing search-db.rdf. Not sure how to say this
in a diff ;).
(Assignee)

Comment 2

15 years ago
Comment on attachment 132267 [details] [diff] [review]
Patch

Neil, I'm not sure if you can review this, but it contains JS code related to
searching RDF. I assume you could review it, but not 100% sure. No actual RDF
in the patch.
Attachment #132267 - Flags: superreview?(jag)
Attachment #132267 - Flags: review?(neil.parkwaycc.co.uk)

Comment 3

15 years ago
Comment on attachment 132267 [details] [diff] [review]
Patch

I think we shouldn't just remove the code for additional datasources, you
should just remove the reference to search-db.rdf from mozillahelp.rdf (?)
Attachment #132267 - Flags: review?(neil.parkwaycc.co.uk) → review-
(Assignee)

Comment 4

15 years ago
That's true. I'll make the change back.
(Assignee)

Updated

15 years ago
Attachment #132267 - Attachment is obsolete: true
Attachment #132267 - Flags: superreview?(jag)
(Assignee)

Comment 5

15 years ago
Created attachment 132279 [details] [diff] [review]
Patch with Neils comments
(Assignee)

Updated

15 years ago
Attachment #132279 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

15 years ago
QA Contact: tpreston → stolenclover
(Assignee)

Updated

15 years ago
Blocks: 220510

Comment 6

15 years ago
Comment on attachment 132279 [details] [diff] [review]
Patch with Neils comments

>-                    nc:datasources="search-db.rdf"
>+                    nc:datasources=""
I've got too many of your patches installed so I can't try this yet, but I
think it should work if you just remove this line without replacing it.
(Assignee)

Comment 7

15 years ago
> I've got too many of your patches installed so I can't try this yet, but I
> think it should work if you just remove this line without replacing it.

Yes, I was thinking of removing this line, but the Search worked fine (with no
JS errors) with this link being blank, and I was hoping that people could use
Mozilla Help as a reference for the help viewer.

There is no reference (at least to my knowledge) about how the help viewer
works, so I want Mozilla Help to demonstrate all of the options that a content
pack can use. This is there just so 3rd parties can know that it's there. If you
think that it's a waste, then I'll remove it.

Comment 8

15 years ago
Hmm... what about changing that line to use the index, rather than coding it?
(Assignee)

Comment 9

15 years ago
> Hmm... what about changing that line to use the index, rather than coding it?

That would work, but I would think that the index should be up by default and
not give a choice to anyone who wishes to use the Help viewer. I consider
searching the index equivalent to searching the TOC or Glossary, which is coded
into help.

Comment 10

15 years ago
Comment on attachment 132279 [details] [diff] [review]
Patch with Neils comments

>-                    nc:datasources="search-db.rdf"
>+                    nc:datasources=""
OK, but I think this should be changed to rdf:null instead.
Attachment #132279 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Updated

15 years ago
Attachment #132279 - Flags: superreview?(alecf)

Comment 11

15 years ago
Comment on attachment 132279 [details] [diff] [review]
Patch with Neils comments

sr=alecf
Attachment #132279 - Flags: superreview?(alecf) → superreview+
(Assignee)

Comment 12

15 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 13

15 years ago
v

several regressions:
"what" returns "what is"
"related" returns "finding related"
neither link makes any sense. We need to clean our Index and Contents db.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.