@mozilla.org/security/nsCertTree;1 doesn't null check mTreeArray

RESOLVED FIXED

Status

--
critical
RESOLVED FIXED
15 years ago
2 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

({crash})

Other Branch
x86
BeOS
crash

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

15 years ago
Create @mozilla.org/security/nsCertTree;1 in xpcshell, interogate it
for interfaces and then access various properties. you will crash.
(Assignee)

Comment 1

15 years ago
Created attachment 132006 [details] [diff] [review]
nullcheck
(Assignee)

Updated

15 years ago
Attachment #132006 - Flags: superreview?(bz-vacation)
Attachment #132006 - Flags: review?(kaie)
Comment on attachment 132006 [details] [diff] [review]
nullcheck

sr=bzbarsky
Attachment #132006 - Flags: superreview?(bz-vacation) → superreview+
Comment on attachment 132006 [details] [diff] [review]
nullcheck

Looks ok. In ::IsContainerEmpty, you could return NS_ERROR_NOT_INITIALIZED,
too, for consistency with your other changes. r=kaie with or without this
change.
Attachment #132006 - Flags: review?(kaie) → review+
(Assignee)

Comment 4

15 years ago
checked in
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Assignee)

Updated

14 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.