If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsIDownload should indicate that Init must be called

RESOLVED FIXED

Status

Core Graveyard
File Handling
RESOLVED FIXED
14 years ago
a year ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

related: bug 220103

In my opinion, nsIDownload should make it clear that its Init function must be
called prior to doing anything else with this interface, to reflect the
behaviour of nsDownloadProxy.
Created attachment 132007 [details] [diff] [review]
patch
Comment on attachment 132007 [details] [diff] [review]
patch

ok opinions on this change?
Attachment #132007 - Flags: review?(bz-vacation)
Status: NEW → ASSIGNED
Comment on attachment 132007 [details] [diff] [review]
patch

Looks good to me.
Attachment #132007 - Flags: review?(bz-vacation) → review+
Attachment #132007 - Flags: superreview?(darin)

Comment 4

14 years ago
Comment on attachment 132007 [details] [diff] [review]
patch

>Index: base/nsIDownload.idl

>      * Initializes the download with certain properties.
>+     * This function must be called prior to accessing any properties on this
>+     * interface.

       * Initializes the download with certain properties.  This function must
       * be called prior to accessing any properties on this interface.

nit pick... seems better to write the comment as a complete paragraph.	but,
sr=darin either way.
Attachment #132007 - Flags: superreview?(darin) → superreview+
checked in, with that change made

Checking in base/nsIDownload.idl;
/cvsroot/mozilla/uriloader/base/nsIDownload.idl,v  <--  nsIDownload.idl
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.