Closed
Bug 220230
Opened 22 years ago
Closed 22 years ago
Change PSM preferences windows behaviour to be more consistent with the rest of the Preference windows
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Stefan.Borggraefe, Assigned: Stefan.Borggraefe)
References
Details
Attachments
(1 file)
|
12.39 KB,
patch
|
KaiE
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
The dialogs and windows in security/manager/pki/resources/content/ opened from
the Preferences dialog are not consistent according to their window behaviour.
The attached patch changes the following:
- the Device Manager and the Certificate Manager are now dialogs like all other
windows opened from Preferences.
- remember the size and position of all resizable dialogs. This way you no
logner have to resize the windows each time.
- change the default size of all dialogs with resizable content from pixel- to
em-values, so they are adaptive to the font size.
- adds "centerscreen" to all modal dialogs so they are placed in the middle of
their parent windows.
- removes "resizable" from all dialogs, that don't have resizable content.
Tested with current Linux and Windows trunk builds.
| Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•22 years ago
|
||
| Assignee | ||
Updated•22 years ago
|
Attachment #132111 -
Flags: review?(kaie)
Comment 2•22 years ago
|
||
Comment on attachment 132111 [details] [diff] [review]
Patch
r=kaie
Please make sure your patch does not reduce functionality, I think we should
not remove resizable flags, I suppose they were introduced for a reason.
Attachment #132111 -
Flags: review?(kaie) → review+
| Assignee | ||
Comment 3•22 years ago
|
||
Comment on attachment 132111 [details] [diff] [review]
Patch
The resizable flag was only removed from dialogs with no resizable content.
These dialogs open with a size so the content fits into them. So this shouldn't
be a problem.
Attachment #132111 -
Flags: superreview?(bienvenu)
Updated•22 years ago
|
Attachment #132111 -
Flags: superreview?(bienvenu) → superreview+
| Assignee | ||
Comment 4•22 years ago
|
||
Checked in by timeless. Thanks for that and the reviews! :-)
Marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•