nsLocalFileWin::Launch should return more specific errors

RESOLVED FIXED in mozilla1.6alpha

Status

()

RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: Biesinger, Assigned: Biesinger)

Tracking

Trunk
mozilla1.6alpha
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

msdn describes the specific error returns of ShellExecute
Attachment #132220 - Flags: superreview?(darin)
Attachment #132220 - Flags: review?(dougt)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.6alpha

Comment 2

15 years ago
Comment on attachment 132220 [details] [diff] [review]
patch

looks fine.  thanks for the patch.  r=dougt
Attachment #132220 - Flags: review?(dougt) → review+

Comment 3

15 years ago
uhm... so how do you plan to make use of these error codes?  what bug does this
block?  if you don't plan to use these error codes, then why add this code?

Comment 4

15 years ago
your not talking about alot of code.  (14 branches and some overhead code).

Comment 5

15 years ago
Comment on attachment 132220 [details] [diff] [review]
patch

true, but it is still a valid question, right? ;-)
Attachment #132220 - Flags: superreview?(darin) → superreview+
I'm planning to use it in the ExternalHelperAppService code, to show users more
friendly error messages when launching a helper application failed. bug is not
yet filed, I will cc you.
Checking in nsLocalFileWin.cpp;
/cvsroot/mozilla/xpcom/io/nsLocalFileWin.cpp,v  <--  nsLocalFileWin.cpp
new revision: 1.109; previous revision: 1.108
done
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.