Need to distinguish between Web links and Help links in Mozilla Help

VERIFIED FIXED

Status

Documentation
Help Viewer
--
enhancement
VERIFIED FIXED
15 years ago
15 years ago

People

(Reporter: Daniel Wang, Assigned: R.J. Keller)

Tracking

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

15 years ago
something like
  a[href^="http://"]:after { content: url('web-link.gif'); }
in the Help css. and an image too
(Reporter)

Comment 1

15 years ago
hmm... I thought Keller is the default owner of doc:user...
Assignee: rudman → rlk
Severity: normal → enhancement
(Assignee)

Comment 2

15 years ago
Maybe a border might be a better idea. or maybe a different background color?
(Assignee)

Comment 3

15 years ago
Accepting.
Status: NEW → ASSIGNED
(Reporter)

Comment 4

15 years ago
border/background won't work because there's no universal color for outgoing
link or local link. Microsoft in its Help files use a little globe icon to
indicate Web resources, hence the css change request
(Assignee)

Comment 5

15 years ago
So do you want a globe? Can you attach this image for me? thanks!
(Assignee)

Comment 6

15 years ago
Daniel, you should file a bug for this at
http://firebirdhelp.mozdev.org/bugs.html under the Layout component.
(Reporter)

Comment 7

15 years ago
Created attachment 132597 [details]
Weblink.svg
(Reporter)

Comment 8

15 years ago
Created attachment 132598 [details]
Weblink.png (8 color black / white)

sorry for the delay. here's a black / white version of the globe, abut the
height of 12pt Arial. I tried various colours & stroke width and found thick
black lines to be the best.
(Assignee)

Comment 9

15 years ago
Created attachment 133163 [details] [diff] [review]
Patch
(Assignee)

Updated

15 years ago
Attachment #133163 - Flags: review?(neil.parkwaycc.co.uk)

Comment 10

15 years ago
Comment on attachment 133163 [details] [diff] [review]
Patch

>+a[href^="http://"]:after { content: url('chrome://communicator/skin/web-link.png'); }
web-links, surely?

Comment 11

15 years ago
Comment on attachment 133163 [details] [diff] [review]
Patch

>+        skin/modern/communicator/web-links.png               (skin/web-links.png)
This would have been skin/modern/web-links.png if the skin had been the correct
place for the image. The image belongs in locale/en-US/images/.

>Index: skin/modern/help.css
This is the wrong file to patch, this is the chrome CSS, you want the content
CSS which is stored in locale. In fact you want both content CSS files for now.

>+a[href^="http://"]:after { content: url('chrome://communicator/skin/web-link.png'); }
So this will become chrome://help/locale/images/web-links.png (and why single
quotes? IIRC style is to use double quotes).
Attachment #133163 - Flags: review?(neil.parkwaycc.co.uk) → review-

Comment 12

15 years ago
Comment on attachment 132598 [details]
Weblink.png (8 color black / white)

Presumably we'll get sued if we colour it ;-)
Attachment #132598 - Attachment filename: Weblink.png → weblink.png
(Assignee)

Comment 13

15 years ago
> This would have been skin/modern/web-links.png if the skin had been the correct
> place for the image. The image belongs in locale/en-US/images/.

I think that the image should be skinned. (In case you haven't noticed, I'm big
on having the help doc CSS skinned ;)). If you don't want it, I'll take it out
but I thought it'd be neat to have everything skinned.

> This is the wrong file to patch, this is the chrome CSS, you want the content
> CSS which is stored in locale. In fact you want both content CSS files for now.

bah. wrong file. sorry! I'm thinking Firebird Help.
(Assignee)

Comment 14

15 years ago
Created attachment 133526 [details] [diff] [review]
Patch with Neil's comments.
Attachment #133163 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #133526 - Flags: review?(neil.parkwaycc.co.uk)

Comment 15

15 years ago
Comment on attachment 133526 [details] [diff] [review]
Patch with Neil's comments.

>+        locale/en-US/help/images/web-links.png             (locale/en-US/images/web-links.png)
>+a[href^="http://"]:after { content: url("chrome://help/locale/web-link.png"); }
>+a[href^="http://"]:after { content-url("chrome://help/locale/web-link.png"); }

These don't match up. The jar.mn calls the file /images/web-links.png but the
stylesheets use /web-link.png and also the second rule uses content-url instead
of content: url
Attachment #133526 - Flags: review?(neil.parkwaycc.co.uk) → review-
(Assignee)

Comment 16

15 years ago
Created attachment 133793 [details] [diff] [review]
Patch v2.1
Attachment #133526 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #133793 - Flags: review?(neil.parkwaycc.co.uk)

Comment 17

15 years ago
Comment on attachment 133793 [details] [diff] [review]
Patch v2.1

>+        locale/en-US/help/images/web-links.png             (locale/en-US/images/web-links.png)
This line above refers to /images/, the two below don't.
>+a[href^="http://"]:after { content: url("chrome://help/locale/web-links.png"); }
>+a[href^="http://"]:after { content: url("chrome://help/locale/web-links.png"); }
(Assignee)

Comment 18

15 years ago
Created attachment 133795 [details] [diff] [review]
Patch v2.2

I apologize neil! I must've not seen your comment on that.
Attachment #133793 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #133795 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Updated

15 years ago
Attachment #133793 - Flags: review?(neil.parkwaycc.co.uk)

Comment 19

15 years ago
Comment on attachment 133795 [details] [diff] [review]
Patch v2.2

Don't forget to cvs add -kb locale/en-US/images/web-links.png
Attachment #133795 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 20

15 years ago
Patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
(Reporter)

Comment 21

15 years ago
v
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.