220460 - "About Popups" dialog is too small with larger fonts, shouldn't be resizable

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Stefan Borggraefe]

Screenshot and patch follow...

I'm not sure if this dialog should perhaps be modal, too. When I make it modal,
it doesn't close itself when the Preferences window come up after clicking the
"Yes" button. It closes then together with the Preferences dialog.

Comment 1

[Stefan Borggraefe]

Attachment: Screenshot showing the bug

Comment 2

[Daniel Wang]

dupe of bug 205573?

Comment 3

[Stefan Borggraefe]

Attachment: Patch

This fixes the bug. I left the dialog non-modal.

Comment 4

[Stefan Borggraefe]

Comment on attachment 132316 [details] [diff] [review]
Patch

Neil: Do you think this dialog should be modal?

Comment 5

[[e-mail]]

Comment on attachment 132316 [details] [diff] [review]
Patch

I think that OpenAboutPopups should definitely be modal; I'm undecided about
the automatic popup dialog...

Comment 6

[[e-mail]]

Asking someone who could shed more light on the modality issue.

Comment 7

[Dan M]

From a user's standpoint the AboutPopups dialog should probably be modal in both
invocations. But there's a technical concern that makes it more trouble than
it's worth. I say make them both dependent, not modal. Details:

There's no technical requirement for this dialog to be modal. But in terms of
user experience, I agree that AboutPopups from the Popups Menu could reasonably
be modal. A modal automatic alert sounds very annoying, especially when
compounded with the popup window it accompanies. Though it'll happen only once,
it's important, you do kind of want to force the user's immediate attention, and
you wouldn't really want the little thing to get lost underneath the big browser
should the user decide to ignore it and refocus the browser. Sounds like it
should be modal, as distasteful as it sounds. (Note the Firebird equivalent is
modal, and Firebird's popup window system was well received.)

There is a technical issue. The user can open the Prefs dialog from Mozilla's
AboutPopups dialog. The Prefs dialog will also be modal when opened from a modal
AboutPopups dialog. Stacks of modal dialogs suck. (The AboutPopups dialog will
attempt to close itself after opening Prefs but if there's modality afoot, it
won't be able to.)

There's a similar issue with Help which Neil has already worked around. However
the same thing can't really be done to the Prefs window, since it breaks the
window.opener property, and some pref panels use that. Dependent dialogs are
everything modal dialogs are, except they're a little gentler. And they're not
implemented on the Mac.

Comment 8

[Stefan Borggraefe]

Attachment: Patch V2

Thanks, Dan, for the clarification. :-) I've already seen some of the problems
you described, when I played around with modality on this dialog. I think using
dependent is the best solution.

So here is a patch with the dependent flag set on the About Popups dialog.
(Otherwise unchanged.)

Comment 9

[[e-mail]]

Comment on attachment 132386 [details] [diff] [review]
Patch V2

danm, good catch.

Comment 10

[[e-mail]]

Fix checked in.