List of properties that are meaningful for :first-line and :first-letter may change

RESOLVED FIXED

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
15 years ago
10 years ago

People

(Reporter: bz, Assigned: mats)

Tracking

({css2})

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [css2.1])

Attachments

(1 attachment, 2 obsolete attachments)

Current drafts of CSS2.1 have some changes to the list of properties that apply
to :first-line and :first-letter pseudo-elements...  Once the draft is in CR, we
should revisit the code in nsHTMLCSSStyleSheet and adjust it as necessary.
And the draft is now in CR.  Taking.
Assignee: dbaron → caillon

Updated

14 years ago
Keywords: css2
OS: Linux → All
Hardware: PC → All
> -  // Disable everything in the nsRuleDataDisplay struct except 'float'

Don't move that comment; it's in the right place.

Updated

14 years ago
Summary: [css2.1] List of properties that are meaningful for :first-line and :first-letter may change → List of properties that are meaningful for :first-line and :first-letter may change
Whiteboard: [css2.1]
(Assignee)

Comment 4

13 years ago
This patch still looks valid, yes?
Attachment #143362 - Flags: review?(dbaron)
(Assignee)

Updated

13 years ago
Blocks: 153781
(Assignee)

Comment 5

13 years ago
Created attachment 166815 [details] [diff] [review]
Patch rev. 2

The first patch did not apply cleanly so I took the liberty of updating it.
I also moved back the comment according to Boris in comment 3.
(Note that this patch also fixes bug 153781 (letter-spacing))
Attachment #143362 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #143362 - Flags: review?(dbaron)
(Assignee)

Updated

13 years ago
Attachment #166815 - Flags: review?(dbaron)
Attachment #166815 - Flags: review?(dbaron) → review+
(Assignee)

Comment 6

13 years ago
Comment on attachment 166815 [details] [diff] [review]
Patch rev. 2

superreview also so we can check it in?
Attachment #166815 - Flags: superreview?(dbaron)
Comment on attachment 166815 [details] [diff] [review]
Patch rev. 2

sr=dbaron as well, but actually don't change text-shadow (i.e., let it continue
to apply).  It was removed from the list of things that apply because it was
removed from CSS 2.1, not because it shouldn't apply.
Attachment #166815 - Flags: superreview?(dbaron) → superreview+
Assignee: caillon → mats.palmgren
Mats - can you land this?
Created attachment 213881 [details] [diff] [review]
updated patch

I removed the 'text-shadow' change, added a removed "." at the end of a sentence, and rewrapped a new comment that was a little wider than the rest.
Attachment #166815 - Attachment is obsolete: true
Attachment #213881 - Flags: superreview+
Attachment #213881 - Flags: review+
Checked in to trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

10 years ago
Blocks: 415476
You need to log in before you can comment on or make changes to this bug.