220626 - Enable keyboard access to Blocked Popups notification bar

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P2)

Description

[Daniel Jackson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030901 Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5b) Gecko/20030901 Firebird/0.6.1+

There's no way to access the "Blocked Popups" window using the keyboard.  


Reproducible: Always

Steps to Reproduce:
1. Navigate to a site that tries to open a popup: the "blocked popups" icon
appears in the status bar
2. Try to access the list of "blocked popups" using the keyboard


Actual Results:  
You cannot access the "blocked popups" list using the keyboard

Expected Results:  
Allowed some access using the keyboard -- perhaps through a tab or button
launching the blocked popups on the "Page Info" dialog box.


Perhaps a nice solution would be to integrate the "Blocked Popups" dialog into a
tab on the "Page Info" dialog.

If this was done, clicking on the "Blocked Popups" status icon would, instead,
take you to this tab on this dialog.

If another tab is not wanted, a "Blocked Popups" button could be added somewhere
on "Page Info" (IMO, this wouldn't be as nice as a tab).

Comment 1

[Mike Connor [:mconnor]]

We're getting REALLY short on keyboard shortcuts...

-> Confirming, taking to evaluate

Comment 2

[Mike Connor [:mconnor]]

we'll figure something out

Comment 3

[athakur]

Seamonkey listed stuff like "Cookie Manager", "Popup Manager", etc. in the Tools
menu (IIRC, I haven't used SeaMonkey in a long time).

Instead of creating a hotkey just for the popup manager, could something like
this could be implemented in Firefox?  Then the user could use the hotkey to
access the tools menu followed by a single key to run the popup manager (i.e.
ALT-T, P).

Comment 4

[Mike Connor [:mconnor]]

we have an idea for something a little more comprehensive, without the kludge
that Seamonkey has.  But that's post-1.0 fodder.

Comment 5

[Asa Dotzler [:asa]]

More basic keyboard accessibility. If we can find a solution for 1.0, that'd be
great. 

Comment 6

[Benjamin Smedberg]

keyboard shortcuts affect l10n... PR or never

Comment 7

[chris hofmann]

anyone close to a patch?

mconnor, is there a link to the future plan?

Comment 8

[Mike Connor [:mconnor]]

chofmann, I don't know if anything is filed, but its linked to the per-site
settings for style etc.  Blake would know, he told me about it a long time ago :)

Do we want a stopgap shortcut for this?

Comment 9

[chris hofmann]

if we could get something that gets us asssibility to the blocked pop ups window
that was pretty low risk that would be great and would get strong consideration
to take next week.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

No keyboard shortcuts, make the infobar focusable, put it into the tab sequence. 

Comment 11

[Asa Dotzler [:asa]]

not going to block the release for this. We need to get the info bar focusable
for 1.0, though.

Comment 12

[Asa Dotzler [:asa]]

p4 priority - not a blocker. if a fully reviewed patch materializes, please
nominate for aviary approval. 

Comment 13

[sairuh (rarely reading bugmail)]

see also bug 262787 for the plugin finder bar.

Comment 14

[sairuh (rarely reading bugmail)]

*** Bug 262787 has been marked as a duplicate of this bug. ***

Comment 15

[Doron Rosenberg (IBM)]

plugin finder bar is accessible already.

Comment 16

[Doron Rosenberg (IBM)]

The easy way would be for the popup bar to have a button rather than require to
click on the messagebar itself.  Or do we want to keep the clicking for IE
compat sake?

Comment 17

[Doron Rosenberg (IBM)]

Attachment: Keeps current behavior by making the infobar's message selectable and the popup show when enter is pressed.

Comment 18

[Doron Rosenberg (IBM)]

aaronl: want to try this out to see if its good enough?

Comment 19

[Doron Rosenberg (IBM)]

Attachment: make space open the popup and the context menu modifier (shift-f10) work, same way IE does.

Comment 20

[Aaron Leventhal]

There should be either a xul:button or xul:menulist there for the options.
Otherwise the screen reader won't know what's up when the text is focused. A
real widget needs focused, plus that's less hacky, and more consistent with what
the plugin finder service does.

Something like " Firefox prevented this site from opening a popup window
<menulist>Popup options</menulist> "

Comment 21

[Doron Rosenberg (IBM)]

Attachment: Add a button and make it show the popup menu.

This patch has a issue where if you use the keyboard (enter/space key) to show
the popup, the popup appears in the top left on the browser window.

Comment 22

[Doron Rosenberg (IBM)]

clearing target milesone.

Comment 23

[Aaron Leventhal]

We should test to make sure this doesn't mess up the XPI installation message
bar, example here: http://ted.mielczarek.org/code/mozilla/extensiondev/

Comment 24

[Aaron Leventhal]

Comment on attachment 176631 [details] [diff] [review]
Add a button and make it show the popup menu.

In the popup setter we should cache the value of
document.getAnonymousElementByAttribute(this, "anonid", "messageButton"

We use it 4 times right in a row.

Comment 25

[Aaron Leventhal]

The UI for popups seems broken in the nightly builds. It says "click here for
options". When I click there I get a menu with 1 item "edit popup blocker
options" and a separate line below that, with no more options.

If we're only going to have 1 thing you can do, we might as well forget the menu
and go straight to the edit popup blocker options dialog.

If we are going to have more than one option in that menu, then I think the
popup blocker warning bar should provide them in a combobox rather than a popup
menu activated by a button.

Comment 26

[Aaron Leventhal]

<button type="menu"> and <button type="menu-button"> should respond to space
bar, down arrow and Enter to be usable as a key navigable solution.

Comment 27

[Aaron Leventhal]

What's the status on this one? Does the current patch address activating the
button via the kbd? I don't see the last few comments addressed in the patch.

Comment 28

[Doron Rosenberg (IBM)]

Comment on attachment 176631 [details] [diff] [review]
Add a button and make it show the popup menu.

This has bitrotted.

Comment 29

[Doron Rosenberg (IBM)]

Attachment: patch for trunk

Comment 30

[Mike Kaply [:mkaply]]

Comment on attachment 181351 [details] [diff] [review]
patch for trunk

a=mkaply

Comment 31

[Doron Rosenberg (IBM)]

checked in.

Comment 32

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381