220741 - [FIX]nsBlockFrame::CombineRects seems redundant

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

This function can be replaced by UnionRect, unless we expect to be combining
rects with negative widths and depend on them being combined "sanely"...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like this

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132388 [details] [diff] [review]
Like this

I did some browsing, and didn't hit any pages where the width is negative for
those rects.... could that ever happen?

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 132388 [details] [diff] [review]
Like this

I think the only possible issue here is the case of blocks with a width or
height of zero not affecting combined area (i.e., overflow area) anymore.  I
wish nsRect didn't have the whole IsEmpty hack...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

Testcase is not regressed by this patch (I tested standards mode too)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in.