220770 - Warning: assignment to undeclared variable gNewAccountToLoad

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Warning: assignment to undeclared variable gNewAccountToLoad
Source File: chrome://messenger/content/accountUtils.js
Line: 206

function msgOpenAccountWizard()
{
  gNewAccountToLoad = null;

  // Check to see if the verify accounts function 
  // was called with callback or not.
  if (gReturnmycall)
      window.openDialog("chrome://messenger/content/AccountWizard.xul",
                        "AccountWizard", "chrome,modal,titlebar,resizable",
{okCallback:WizCallback});
  else
      window.openDialog("chrome://messenger/content/AccountWizard.xul",
                        "AccountWizard", "chrome,modal,titlebar,resizable");

  loadInboxForNewAccount();

  //For the first account we need to reset the default smtp server in the panel.
  var smtpService =
Components.classes["@mozilla.org/messengercompose/smtp;1"].getService(Components.interfaces.nsISmtpService);
  var serverCount = smtpService.smtpServers.Count();
  try{ReloadSmtpPanel();}
  catch(ex){}
}

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch, delcare it with var

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Patch without my changes for bug 220768

Comment 3

[[e-mail]]

Comment on attachment 132401 [details] [diff] [review]
Patch without my changes for bug 220768

If this is the right place to declare this variable then that means that
msgMail3PaneWindow.js is the wrong place to declare it.

Comment 4

[Karsten Düsterloh]

taking, as agreed upon on IRC

Comment 5

[Karsten Düsterloh]

Attachment: patch

- moved the definition of gNewAccountToLoad from msgMail3paneWindow.js to
accountUtils.js
- extended msgOpenAccountWizard by an argument to sustain calling context
- changed calls to msgOpenAccountWizard to reflect that
(and I removed an argument in a function call that is useless since its
implementation - the function never had any parameters...)

Comment 6

[[e-mail]]

Sorry, I don't see the point of changing msgOpenAccountWizard, explain please?

Comment 7

[Karsten Düsterloh]

Attachment: simplified patch

No point there, sorry. :|
I've skipped the unnecessary changes to msgOpenAccountWizard, so that's what
remains:
- moved the definition of gNewAccountToLoad from msgMail3paneWindow.js to
accountUtils.js (gNewAccountToLoad gets only used there and in
AccountWizard.js; AccountWizard.js is only included by AccountWizard.xul, and
accountUtils.js is included there, too)
- removed an argument in a function call that is useless since its
implementation in rev 1.3

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 132576 [details] [diff] [review]
simplified patch

sr=bzbarsky

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in prefs/resources/content/accountUtils.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/accountUtils.js,v  <--  a
ccountUtils.js
new revision: 1.32; previous revision: 1.31
done
Checking in resources/content/msgMail3PaneWindow.js;
/cvsroot/mozilla/mailnews/base/resources/content/msgMail3PaneWindow.js,v  <--  m
sgMail3PaneWindow.js
new revision: 1.250; previous revision: 1.249
done

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with the 2004-08-20-07 build on Windows XP Seamonkey Trunk.