220894 - Add UI for automatic emptying of trash for local folders on exit

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, enhancement)

Description

[Simon Billingsley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla Thunderbird 0.3a (20030914)

When I delete a mail message from a local folder, the message goes to the Trash
folder in the local folders account (which I guess is the expected behaviour).
I have a filter to move mail messages to local folders for me - but then like to
delete them.
I have set the POP/IMAP account options to empty the trash on exit - which it
does but the folder is empty.
The local folder trash doesn't get emptied on exit and there is no option to
turn it on.

Reproducible: Always

Steps to Reproduce:
1.'Delete' a Local folder mail message (move it to trash)
2. I appears in the Local folder trash
3. Exit Thunderbird - the normal account trash gets emptied
4. Restart Thunderbird
Actual Results:  
The local folders trash still has messages.

Expected Results:  
An option for the local folders to allow the trash to be emptied on exit would
be nice.
Proposed Actual Results: Local folder trash gets emptied & will be empty on
start up.

Comment 1

[Jo Hermans]

Can't you use the 'Empty Trash' in the context menu (right-click) or in the File
menu (menubar) ? That works for me.

Comment 2

[Jungshik Shin]

The reporter is asking for _automatic_ emptying of local trash folder on exit. 

Comment 3

[Travis Chase]

why not just have all trash go to one place instead.

Comment 4

[David Frahm]

I agree with comment #3, and would like to add the following:

As someone with usability testing experience specifically related to email
clients, I feel the current account options regarding account vs. local folders
and how drafts, templates, junk and trash is handled is WAY too cumbersome for
most *normal* people.

I've been using thunderbird 0.5 and now 0.6 and there's no way any of my family
or friends who are not developers could figure this out.

All of the individual options are overwhelming.  However, it seems to me like
the overall concept might be more simple than all the options make it to appear...

Why not have a simple toggle for handling all the "special" folders (drafts,
templates, junk, trash, etc.) either in their individual accounts or in the
Local Folders?  When individual is chosen, the special folders under Local
Folders should not display, and vise-versa for when local folders is chosen.

I would be surprised if many people combine the two, as it would probably be too
confusing to have drafts handled individually but trash globally.  The user's
mental model of the application is probably such that they think of each account
imdividually or all as a group.  Of course, only user testing can prove that.

Comment 5

[Tommy Becker]

David, I agree with what you're saying, but I don't think this particular bug is
the proper forum for those issues.  The Empty Trash on Exit functionality is
currently in for POP (and I presume IMAP) accounts, but not Local Folders.  This
is just inconsistent and annoying, especially when you forget to ever empty your
trash because you're used to having it done automagically.  Considering the
excellent work being done on bug 30057, I think a lot of folks are going to be
deferring their accounts to Local Folders, and at that point this "bug" should
get a lot more attention.

Comment 6

[Travis Chase]

*** Bug 240505 has been marked as a duplicate of this bug. ***

Comment 7

[Tommy Becker]

Nominating to block 1.0.  Probably gonna get shot down, but this is a major pet
peeve of mine, and it seems like it should be easy enough to implement.

Comment 8

[David :Bienvenu]

with the global inbox, this bug becomes that much more important.

Comment 9

[[e-mail]]

Stefan, bienvenu says this is simply a matter of adding UI ;-)

Comment 10

[Stefan Borggraefe]

(In reply to comment #9)
> Stefan, bienvenu says this is simply a matter of adding UI ;-)

Indeed, setting the pref via about:config works as expected. Let's add a
checkbox for this. :-)

Comment 11

[Stefan Borggraefe]

Attachment: Patch diff -u

Applies to both trunk and aviary-branch.

I also added a groupbox around the new checkbox and the "Local directory"
textbox, because otherwise this looks ugly IMHO.

The accesskey for the new checkbox is "x" and not "E" for consistency with the
checkbox on the Server Settings pane of normal mail-accounts.

Comment 12

[Stefan Borggraefe]

Attachment: Patch diff -uw

Same patch, diff -uw.

Comment 13

[Scott MacGregor]

Comment on attachment 157687 [details] [diff] [review]
Patch diff -uw

looks great stefan.

Comment 14

[Stefan Borggraefe]

Fixed on trunk, too. Thanks for the reviews!