221073 - Erroneous calendar files ( *.ics ) should not make Calendar fail silently

Status: RESOLVED WORKSFORME

(Calendar :: General, defect)

Description

[Vlady]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5a) Gecko/20030728 Mozilla Firebird/0.6.1

i've had problems with calendar in the past which got me to manually edit the
.ics file, now the calendar won't show anything.  Seems, like i just screwed up
the file right?  Well its pretty hard to screw up, and iCal is able to parse it
just fine, why can't mozilla calendar?

http://www.icalx.com/html/hitotest/day.php?cal=CalendarDataFile  l:test p:test

Reproducible: Always

Steps to Reproduce:





here's the .ics file:

BEGIN:VCALENDAR
VERSION
 :2.0
PRODID
 :-//Mozilla.org/NONSGML Mozilla Calendar V1.0//EN
BEGIN:VEVENT
UID
 :125766e0-e7f2-11d7-b680-c8db907fd786
SUMMARY
 :Astro 112
LOCATION
 :182 Denn
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=MO,WE,FR
DTSTART
 :20030917T100000
DTEND
 :20030917T110000
DTSTAMP
 :20030916T030043Z
END:VEVENT
BEGIN:VEVENT
UID
 :311fb0d0-e7f2-11d7-9e0e-826a9ebb1322
SUMMARY
 :bio 162
LOCATION
 :mlb aud 3
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=MO,WE,FR
DTSTART
 :20030917T120000
DTEND
 :20030917T130000
DTSTAMP
 :20030916T030159Z
END:VEVENT
BEGIN:VEVENT
UID
 :5ba11f00-e7f2-11d7-a583-cf42f49020ec
SUMMARY
 :Hist 285 D
LOCATION
 :3429 Denn
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=MO
DTSTART
 :20030915T150000
DTEND
 :20030915T160000
DTSTAMP
 :20030916T030302Z
END:VEVENT
BEGIN:VEVENT
UID
 :6af3b150-e7f2-11d7-82fe-f692322c6890
SUMMARY
 :bio 105 D
LOCATION
 :1223 Chem
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=MO
DTSTART
 :20030915T160000
DTEND
 :20030915T170000
DTSTAMP
 :20030916T030338Z
END:VEVENT
BEGIN:VEVENT
UID
 :7f86f8a0-e7f2-11d7-aa7f-98a766614862
SUMMARY
 :Hist 285
LOCATION
 :269 Denn
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=TU,TH
DTSTART
 :20030916T100000
DTEND
 :20030916T110000
DTSTAMP
 :20030916T030406Z
END:VEVENT
BEGIN:VEVENT
UID
 :9a402b10-e7f2-11d7-911f-d4924235f27e
SUMMARY
 :bio 105 D
LOCATION
 :1328 Chem
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=TU
DTSTART
 :20030916T130000
DTEND
 :20030916T150000
DTSTAMP
 :20030916T030450Z
END:VEVENT
BEGIN:VEVENT
UID
 :b2a56a60-e7f2-11d7-8aa4-e2c2b0fea141
SUMMARY
 :Bio 162 Lab
LOCATION
 :1060
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=WE
DTSTART
 :20030917T190000
DTEND
 :20030917T220000
DTSTAMP
 :20030916T030534Z
END:VEVENT
BEGIN:VEVENT
UID
 :ef2f83b0-e7e9-11d7-a97d-9d6a71d3c76e
SUMMARY
 :bio 105 report due
STATUS
 :CONFIRMED
CLASS
 :PRIVATE
DTSTART
 :20030915T090000
DTEND
 :20030915T100000
DTSTAMP
 :20030916T020257Z
END:VEVENT
BEGIN:VEVENT
UID
 :2ae17430-e7f3-11d7-9151-c12c2f48db7d
SUMMARY
 :bio 105 report due
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
DTSTART
 :20030922T080000
DTEND
 :20030922T080500
DTSTAMP
 :20030916T030858Z
END:VEVENT
BEGIN:VEVENT
UID
 :224d7a40-e7f2-11d7-9bc5-e0c41fbbd204
SUMMARY
 :bio 105
LOCATION
 :170 denn
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=MO,WE,FR
DTSTART
 :20030917T110000
DTEND
 :20030917T120000
DTSTAMP
 :20030916T030134Z
END:VEVENT
BEGIN:VEVENT
UID
 :641d4d70-e7f8-11d7-a04d-c83b77f10976
SUMMARY
 :mom comming here
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
DTSTART
 :20030916T153000
DTEND
 :20030916T153500
DTSTAMP
 :20030916T034628Z
END:VEVENT
 
BEGIN:VCALENDAR
BEGIN:VEVENT
UID
 :bbd1be20-e877-11d7-8585-ec5cbd0b14a3
SUMMARY
 :Work
LOCATION
 :HITO
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
RRULE
 :FREQ=WEEKLY;UNTIL=20031210;INTERVAL=1;BYDAY=TH
DTSTART
 :20030918T120000
DTEND
 :20030918T170000
DTSTAMP
 :20030916T185749Z
END:VEVENT
BEGIN:VEVENT
UID
 :c3d77a20-e877-11d7-88ca-b3d995b5dacb
SUMMARY
 :Work
LOCATION
 :HITO
STATUS
 :TENTATIVE
CLASS
 :PRIVATE
DTSTART
 :20030919T130000
DTEND
 :20030919T170000
DTSTAMP
 :20030916T185824Z
END:VEVENT
END:VCALENDAR

Comment 1

[Vlady]

still does it in the new january version w/thunderbird 0.4

Comment 2

[Jussi Kukkonen]

Well, there are two BEGIN:VCALENDAR tags and only one END:VCALENDAR in your
file. So it is clearly broken.

Still, I'll leave this open, a 'silent fail' is not the correct way to handle
this  caseb - we should either read the file or complain about a malformed file. 

Confirming, changing summary.

Comment 3

[Vlady]

even after taking out everything after and including begin:calendar but leaving
end:calendar does not fix the problem with newest install in thunderbird 0.4. 
the program asks if i want to see the 11 events but doesn't show them after wards.  

Comment 4

[Jussi Kukkonen]

Attachment: fixed test case by removing BEGIN:VCALENDAR

Vlad, could you tell _exactly_ what you are doing that is failing?
What you write in comment 3 sounds like importing, but you haven't mentioned
that that is what you are trying to do.

My tests (on 20040223 build):
* Import
   -Works with the ics in comment 0

* Use as normal (non-remote) calendar file
   -doesn't work with ics in comment 0 (b/c of duplicate BEGIN:VCALENDAR)
   -works with a modified ics (attached)

Comment 5

[Vlady]

ur right, i was trying to do an import.  the file i have locally wasn't working,
but i tried the one that you attached and it worked.  so it must be my fault in
modifying the file, and not the calendar's.

Comment 6

[Joey Minta]

(In reply to comment #5)
>...  so it must be my fault in
> modifying the file, and not the calendar's.

Vlady,
   If this is the case, is there any reason to keep this bug open?  If not, can
you please mark it resolved?

Comment 7

[Vlady]

yes

Comment 8

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: General. Be afraid for your sanity!