221126 - Warnings in unix_rand.c

Status: RESOLVED INCOMPLETE

(NSS :: Libraries, defect, P3)

Description

[timeless]

In file included from /swap/BEOS/mozilla/security/nss/lib/freebl/sysrand.c:36:
/swap/BEOS/mozilla/security/nss/lib/freebl/unix_rand.c:
 In function `RNG_SystemInfoForRNG':
831: warning: assignment from incompatible pointer type
840: warning: implicit declaration of function `gethostname'

Comment 1

[timeless]

Attachment: remove incorrect const marking

Comment 2

[Julien Pierre]

Comment on attachment 132580 [details] [diff] [review]
remove incorrect const marking

I think the include part of the patch is OK. But the second part if not. If you are going to change the type of cp, you need to change all the casts, and the environ declaration. I'm not sure if that will work on all Unix platforms.

Comment 3

[Atul Aggarwal]

I don't see any warning on linux. But the warning might be specific to BeOS due to #ifdef. But I would suggest closing this one and opening new one if we find some warnings in BeOS as this is a bug not tortoise (already lifespan of 8 years).

Comment 4

[:Cykesiopka]

It looks like incompatible pointer type issue was fixed in Bug 265369.

(See http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/security/nss/lib/freebl&command=DIFF_FRAMESET&file=unix_rand.c&rev1=1.16&rev2=1.17&root=/cvsroot )


Does the code still warn about the implicit declaration?

Comment 5

[timeless]

bug 265369 seems to have resolved one of two warnings for this file.

I don't have BeOS particularly handy, but I'm pretty sure that it would still warn about the implicit declaration. There certainly haven't been any changes to the file that would resolve it.

I don't see any includes in the relevant directory for the file.

Comment 6

[Chris Peterson [:cpeterson]]

timeless, do you know if anyone is maintaining NSS for BeOS or Haiku? Can we WONTFIX open BeOS bugs?

Comment 7

[timeless]

I do not know. I haven't worked on Mozilla at all in 5 years...

Comment 8

[Chris Peterson [:cpeterson]]

Thanks. I'm going to close this bug because the warning was apparently fixed in 2005 by bug 265369, according to comment 5. :)