Recent gtk widget changes broke build for commercial compilers

VERIFIED FIXED

Status

()

Core
XUL
P3
blocker
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: tor, Assigned: Stuart Parmenter)

Tracking

Trunk
Sun
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
I'm seeing these problems on SUNWspro 4.2, but most likely other commercial
C++ compilers are breaking the same way.  A patch is attached; the first bit
for nsDragService.h adds "static" to the method which is passed to GTK as
a callback.  The second bit for nsGtkEventHandler.cpp essentially backs out
pavlov's latest changes, as NS_STATIC_CAST was causing problems when
NS_RELEASE tried to assign the resulting casted pointer a zero value.
The casted pointer is not an lvalue, as even g++ will admit if you pass
it "-pedantic".
(Reporter)

Comment 1

18 years ago
Created attachment 3620 [details] [diff] [review]
Patch described in bug report
(Assignee)

Updated

18 years ago
Assignee: blizzard → pavlov
(Assignee)

Comment 2

18 years ago
reassigning to me.  this patch works.  my compiler was getting confused about
which addref and release to use so i added the static casts, but it no longer
seems to be confused...  so i'm confused.. heh  but other than that, the patch
looks good.  emailing chofmann to see if i can check it in.
(Assignee)

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

18 years ago
checked in patch

Updated

18 years ago
QA Contact: paulmac → tor

Comment 4

18 years ago
tor@cs.brown.edu please verify, thanks
(Reporter)

Updated

18 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Comment 5

18 years ago
Fix is in, SUNWspro is happy.
You need to log in before you can comment on or make changes to this bug.