Move current attach items to submenu of File

VERIFIED FIXED

Status

MailNews Core
Composition
VERIFIED FIXED
14 years ago
9 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

14 years ago
In 4xp we used to have all the attach items as a submenu of File menu within the
compose window, similar to the Save As submenu.
(Assignee)

Comment 1

14 years ago
Created attachment 132969 [details] [diff] [review]
Patch v0.1 that moves Attach items to new submenu

New Attach submenu that contains same choices at attach button on compose
window. Attach vCard is still in the options menu as well though.
(Assignee)

Updated

14 years ago
Attachment #132969 - Flags: review?(neil.parkwaycc.co.uk)

Comment 2

14 years ago
Comment on attachment 132969 [details] [diff] [review]
Patch v0.1 that moves Attach items to new submenu

Please clean up the strings a bit.
Attachment #132969 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 3

14 years ago
Created attachment 132996 [details] [diff] [review]
Patch v0.2 that creates new Attach submenu and does some tidy up

Moves attach choices from file into new Attach submenu of file and also adds
the vCard attachmenu to that submenu as it was under NS4.x. String names have
been cleaned up and redundant ones removed.
(Assignee)

Updated

14 years ago
Attachment #132969 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #132996 - Flags: review?(neil.parkwaycc.co.uk)

Comment 4

14 years ago
Comment on attachment 132969 [details] [diff] [review]
Patch v0.1 that moves Attach items to new submenu

Oops, that seems to have made things worse - I forgot about the context menu
:-[
Attachment #132969 - Attachment is obsolete: false
Attachment #132969 - Flags: review+

Updated

14 years ago
Attachment #132996 - Attachment is obsolete: true
Attachment #132996 - Flags: review?(neil.parkwaycc.co.uk)
(Assignee)

Comment 5

14 years ago
Created attachment 133076 [details] [diff] [review]
Patch v0.3 - creates new Attach submenu, attach page to bucket and general clean up

Revised patch that adds Attach submenu to File menu, adds attach web page to
attachment bucket context menu and does some general tidy up of string names.
Attachment #132969 - Attachment is obsolete: true
(Assignee)

Updated

14 years ago
Attachment #133076 - Flags: review?(neil.parkwaycc.co.uk)

Comment 6

14 years ago
Comment on attachment 133076 [details] [diff] [review]
Patch v0.3 - creates new Attach submenu, attach page to bucket and general clean up

Although if you insist...

>+<!ENTITY attachCmd.label "Attach">
>+<!ENTITY attachCmd.accesskey "t">
I think these should be attachMenu (SaveAs incorrectly uses Cmd but Priority,
returnReceipt, outputFormat and fileHere use Menu)

>+<!ENTITY attachFile.label "File(s)...">
>+<!ENTITY attachFile.key "">
>+<!ENTITY attachFile.accesskey "F">
>+<!ENTITY attachPage.label "Web Page...">
>+<!ENTITY attachPage.accesskey "W">
>+<!--LOCALIZATION NOTE attachVCard.label Don't translate the term 'vCard' -->
>+<!ENTITY attachVCard.label "Personal Card (vCard)">
>+<!ENTITY attachVCard.accesskey "P">
I would have said attachXXXCmd.* except this conflicts with the options version
of the vCard which should in theory also be attachVCardCmd as the original l10n
note suggests.

>-<!--LOCALIZATION NOTE attachVCardCmd.label Don't translate the term 'vCard' -->
>+<!--LOCALIZATION NOTE attachVCardMenu.label Don't translate the term 'vCard' -->
> <!ENTITY attachVCardMenu.label "Attach Personal Card (vCard)">
> <!ENTITY attachVCardMenu.accesskey "v">
Sigh. Maybe just attachVCard.*?

> <!ENTITY delete.label "Delete">
> <!ENTITY delete.accesskey "D">
> <!ENTITY selectAll.label "Select All">
> <!ENTITY selectAll.accesskey "A">
>+<!ENTITY attachFileBucket.label "Attach File(s)...">
>+<!ENTITY attachFileBucket.accesskey "F">
>+<!ENTITY attachPageBucket.label "Attach Web Page...">
>+<!ENTITY attachPageBucket.accesskey "W">
Drop Bucket, the other context items don't use it.
Attachment #133076 - Flags: review?(neil.parkwaycc.co.uk) → review+
(Assignee)

Comment 7

14 years ago
Created attachment 133125 [details] [diff] [review]
Patch v0.3a - gives Attach submenu, attach page in bucket and string clean up

Taking on board Neil's comments
(Assignee)

Updated

14 years ago
Attachment #133076 - Attachment is obsolete: true
(Assignee)

Comment 8

14 years ago
Taking from sspitzer@mozilla.org (Seth Spitzer)
Assignee: sspitzer → bugzilla
(Assignee)

Comment 9

14 years ago
Accepting
Status: NEW → ASSIGNED
(Assignee)

Comment 10

14 years ago
Comment on attachment 133125 [details] [diff] [review]
Patch v0.3a - gives Attach submenu, attach page in bucket and string clean up

Carrying forward r=
Attachment #133125 - Flags: superreview?(bienvenu)
Attachment #133125 - Flags: review+

Comment 11

14 years ago
Comment on attachment 133125 [details] [diff] [review]
Patch v0.3a - gives Attach submenu, attach page in bucket and string clean up

I'm not crazy about having this in three places, but it is consistent with 4.x,
I guess...removing it from the options menu is a possibility, I think.
Attachment #133125 - Flags: superreview?(bienvenu) → superreview+

Comment 12

14 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Comment 13

14 years ago
I agree with David. I think we should remove the vCard option from the Options
menu. I'm doing that in thunderbird FWIW. 
(Assignee)

Updated

14 years ago
Blocks: 222997
Product: MailNews → Core
Verified FIXED using build 2006-01-06-09 of SeaMonkey trunk on Windows XP.
Status: RESOLVED → VERIFIED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.