221484 - use nsCOMArray.Sort() in AutoComplete results, and other cleanup

Status: RESOLVED WORKSFORME

(Core Graveyard :: History: Global, defect)

Description

[Alec Flett]

Now that we have bug 211535 fixed, we can get rid of the intermediate
nsIAutoCompleteItems** that is used here:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/history/src/nsGlobalHistory.cpp#4198

that is used for sorting. What we probably also want to do is make a new helper
function in nsArray.h called NS_AppendElements(nsIMutableArray* dest, const
nsCOMArray& elements); 
around here: http://lxr.mozilla.org/seamonkey/source/xpcom/ds/nsArray.h#67

And then change nsIAutoCompleteResults' "items" array to be an nsIArray... this
would clean up a whole host of junk.

Comment 1

[Patrick McCormick]

I opened two bugs to track the aspects of this bug that still exist in FB; see 
bug 233479 and bug 233481.

Comment 2

[Patrick McCormick]

Attachment: add NS_AppendElements to nsArray.h

Comment 3

[Alec Flett]

Comment on attachment 140922 [details] [diff] [review]
add NS_AppendElements to nsArray.h

do we want to make aWeak default to PR_FALSE? either way, sr=alecf

Comment 4

[Ben Karel [eschew]]

Is this bug relevant any more? It seems that most of the underlying code has changed in the last three years so that the original issues here are no longer valid.

Not sure what the proper resolution for an expired bug is, so I'll leave resolution to someone more experienced in Bugzilla.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Probably WFM is the way to go.